Since many different Feeds sources can pull from a single Mailhandler mailbox (including comment importers, which don't support commands), it probably makes more sense for "default commands" to be configured on a per-importer or per-source node basis. I'm not sure which is most appropriate, any opinions?

Note that this wouldn't change how commands are processed, just where they're configured by users.

Comments

Ian Ward’s picture

I agree, makes sense. Per importer sounds good; they'll then be easily exportable (w/ the importer).

danepowell’s picture

Issue tags: +mailflow 2.x

Tagging to keep track of issues related to the mailhandler-2.x/notifications-4.x workflow

danepowell’s picture

Title: Move "default commands" configuration from mailbox to fetcher, parser, or source » Move "default commands" and "signature separator" configuration from mailbox to parser
danepowell’s picture

Status: Active » Fixed

Done- note that with this commit I also changed the parameters for command parsers and processors, since they no longer need a copy of the mailbox object. Also note that signature separation, although it can be configured, still doesn't work (it has never been implemented in 2.x)- that's a separate issue.

Status: Fixed » Closed (fixed)
Issue tags: -mailflow 2.x

Automatically closed -- issue fixed for 2 weeks with no activity.