Still maintained?

Okay; thanks.

Would you be interested in hearing suggestions for enhancements? I have a few. Perhaps I'll just bowl on in and give the ones that occur to me now:

- Views integration, so one could filter by forwarded address (useful for finding which email alias is bouncing!)
- More forgiving forwarding field (strip whitespace and blank lines automatically)
- Edit own mailfix settings permission (at least for the forwarding address)

I'm still learning PHP, but have made a few changes to the module to suit my needs, including the last item there. I'm not making any claim that they're suitable for merging, but will perhaps be helpful in seeing what I'm talking about (or telling me I've introduced bugs!)

Here's a simple module I made this afternoon that adds views integration. Would you be willing to include the (small amount of) code from it in Mailfix?

I realise that it would probably be good to do a field formatter for the value of the forwarding field. I've taken the lazy way for now and used the views customfield module.

Thanks!

Oh, the other thing I forgot to mention was that I added a "change own email address" permission (disabled for mailfix users). I did this when still starting out (by patching core), and haven't gotten around to doing it properly yet, so I won't provide a patch for that.

You have a good weekend too!

Thanks!

Nigel

Oh, that reminds me... (and sorry for the avalanche of messages!) ... have you considered some way of (optionally) stopping people from registering their own accounts in mailfix domains?

I've thought about the possibility, and downloaded a module or two that look like they apply restrictions at user registration time, but haven't yet properly gotten around to it.

Regards,

Nigel

Ping!

I'm willing to help if you'd be willing to give me commit access.

FWIW, I just found and fixed a bug that would cause mailfix profiles to be deleted if you edited secondary tabs in a user profile. The problem was missing 'break;' in the mailfix_user function (at the end of the 'update' section of the case statement. 'form' should also have one.

Regards,

Nigel

> I'm sorry for not having included your changes, I've been running out of
> time. I just tried to grant you access, but I received this message:
> NigelCunningham does not have a CVS account.

Okay. I'll apply for one; thanks for being willing - I'll let you know when it's approved.

> In the mean time (I know by experience it can take a while to get a CVS
> account) I will commit your changes, I have more extra times since
> yesterday, and there are a couple of features I need updated in this
> module.

Okay; thanks!

> Thank you for finding and fixing this bug,

Not a problem.

Nigel

Hi again.

Looking at my first patch, I see that I introduced the bug just fixed, when I added the if clause in the case statement. It's not a bug in the currently committed code.

That was incredibly fast. Thanks very much kiamlaluno!

alxsvdr, are you happy for me to start splitting that big patch above up, testing more thoroughly and committing?

Regards,

Nigel

Okay; thanks.

I have lots of projects on the go at once, so it won't happen immediately, but I will make a start.

I should close this issue as fixed, too, shouldn't I?

Nigel