Compatibility with Mailhandler 6.x-2.x [#989924]

It seems that Mailcomment 6.x-2.x is not yet compatible with Mailhandler 6.x-2.x. Specifically, mailcomment_mailhandler_node_presave is never called in my test environment, and I can't tell exactly what hook it's supposed to be implementing (it looks a bit like hook_nodeapi(), but that doesn't seem right). Even if this hook were called, I don't think this would work, as I don't think Mailhandler 2.x has the capacity to save comments anymore. It seems like Mailcomment is going to have to actually save the comment.

I'd like to put in some legwork on this if you don't have time, but I would appreciate some pointers on how to get started, since you're obviously much more familiar with the 2.x architecture :)

Comments

Comment #1

cor3huis commented 22 December 2010 at 03:15

possibly mailcomment_mailhandler_comment_nodeapi()... Have issues myself with comment_presave so you issue could also be in the comment.module. I'm using D6.19

Comment #2

Ian Ward commented 22 December 2010 at 12:50

Just noting the issue related to this in mailhandler is http://drupal.org/node/947266

Comment #3

tbenice commented 14 January 2011 at 22:34

subscribing.

Comment #4

tbenice commented 21 January 2011 at 16:38

Since mailhandler 2.x uses feeds to import mail, maybe mailcomment needs to inject some info into notifications mail headers (eg nid, pnid) and define a new importer based on the mailhandler ldap parser that can read them? There's already a comment mapper module so it could use that.
Does that make sense? I need this functionalit for a client and don't want to go backward to prev versions.

Comment #5

danepowell commented 21 January 2011 at 17:50

Just FYI, most of the work on this is taking place in the Mailhandler module (see #1029352: Cleaning up authentication, and other high-level restructuring and #947266: Consider how to handle comments). I believe the current plan is to move some of the mailcomment functions into the mailhandler parser, then use the Feeds Comment Processor module to actually post the comments.

Beyond that, some configuration options probably need to be moved from the Mailcomment site-wide config form into the Feeds Importer configuration form.

Comment #6

tbenice commented 21 January 2011 at 18:57

That sounds great. I'm motivated to get this so am happy to help any way I can.

Am I right in thinking that Mailcomment will still need to modify the notifications emails in a new way so that the return message has the needed information for the Feeds Comment Processor to map to comments (nid for node creation and update events, parent-cid for comment events)?

I haven't looked closely at the mailcomment code yet, but will happily work on a patch for the above if it is needed.

EDIT: Ok, I see that the appropriate header info is there already.