Followup on #823916: Domain Access and Mailchimp, for Mailchimp 7.x-5.x.
Mailchimp doesn't have support for Domain Access.

CommentFileSizeAuthor
#4 mailchimp-domain_access_support-3017168-2-reroll.patch1.15 KBrjacobsen0
#2 mailchimp-domain_access_support-3017168-2.patch1.15 KBtvoesenek

Comments

TVoesenek created an issue. See original summary.

tvoesenek’s picture

tvoesenek commented
Status: Active » Needs work
StatusFileSize
new mailchimp-domain_access_support-3017168-2.patch1.15 KB

For the project I'm working on, we don't use any submodules of Mailchimp, so I've only re-rolled the part of the patch from #823916: Domain Access and Mailchimp #12 which adds the domain id to the cid when caching the listst. I currently don't have the time to re-roll the other parts of the patch, so feel free to update this patch!

paulvandenburg’s picture

paulvandenburg commented
Status: Needs work » Reviewed & tested by the community 
+++ b/mailchimp.module
@@ -286,7 +286,12 @@ function mailchimp_get_list($list_id, $use_interest_groups = TRUE, $reset = FALS
+    $cid .= ':'.$current_domain['machine_name'];

According to coding standards there should be spaces around the concatenation operator.

But the patch works great and I don't think this minor thing should hold this up. So marking as RTBC.

rjacobsen0’s picture

rjacobsen0 commented
Assigned: Unassigned » rjacobsen0
StatusFileSize
new mailchimp-domain_access_support-3017168-2-reroll.patch1.15 KB

Re-rolled.

  • rjacobsen0 committed facec63 on 7.x-5.x authored by TVoesenek 
    Issue #3017168 by TVoesenek, rjacobsen0: Domain Access support in...
rjacobsen0’s picture

rjacobsen0 commented
Status: Reviewed & tested by the community » Fixed

The re-roll wasn't necessary after I got on the correct branch (7.x-5.x). The original patch was applied and committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.