Hello

I've faced with SQL error "Duplicate entry in table mail_edit_registry".

The reason of problem is that you use INNER JOIN in function mail_edit_features_content_get().
But some mail templates can be added only into table mail_edit_registry via hook_mailkeys() and function mail_edit_features_content_get() would not return these templates.

And then in function mail_edit_features_features_rebuild() we can have situation with inserting of the duplicate entries.

CommentFileSizeAuthor
#3 mail_editor_features-duplicate_entry-2576207-3.patch1.01 KBwesleydv
#2 mail_editor_features-duplicate_entry-2576207-2-D7.patch1.01 KBeugene.ilyin

Comments

eugene.ilyin created an issue. See original summary.

eugene.ilyin’s picture

eugene.ilyin commented
Status: Active » Needs review
StatusFileSize
new mail_editor_features-duplicate_entry-2576207-2-D7.patch1.01 KB

I have attached patch to fix this problem.

wesleydv’s picture

wesleydv commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new mail_editor_features-duplicate_entry-2576207-3.patch1.01 KB

Patch #2 tested and works
Added a new patch to remove some unnecessary whitespace

RTBC because I only removed some whitespace.

IRuslan’s picture

IRuslan commented
Related issues: +#2459459: Refactor mail_edit_features_content_get to return all registry lines even without translation!

  • IRuslan committed c9be5c1 on 7.x-1.x authored by eugene.ilyin 
    Issue #2576207 by eugene.ilyin, wesleydv, IRuslan: Duplicate entry in...
IRuslan’s picture

IRuslan commented
Status: Reviewed & tested by the community » Fixed

Pushed to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.