Email to OG fields don't work on PHP 5.3 -- no data is saved. At least, this is the case when the field is created on PHP 5.3; I didn't test migrating an existing site to PHP 5.3.

The fix seems to be pretty simple: don't pass $field by reference in the hook_field_settings() implementation.

CommentFileSizeAuthor
mail2og-php53.patch613 bytesmfb

Comments

jludwig’s picture

jludwig commented
Status: Needs review » Postponed (maintainer needs more info)

I'm not having any problems with the module as it is on PHP 5.3. I don't want to commit this patch if I'm not sure if it fixes anything. Can someone verify that the fields are broken without this patch?

  • mfb authored 6327645 on 6.x-2.x 
    Issue #965168 by mfb: Email to OG field does not work on PHP 5.3

  • mfb authored 98e11b1 on 6.x-1.x 
    Issue #965168 by mfb: Email to OG field does not work on PHP 5.3
jludwig’s picture

jludwig commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Fixed

Committed in both branches. I should have done this a long time ago. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.