I'm not sure if this is the best place to post this, but I have run Magic Tabs through the code review module and converted most of it to 6.4 and corrected some code convention issues.

The part I got stuck on was the New hook_theme registry conversion.
That part is marked by the notation:
/**
* Stuck here -- the function above needs to be adapted to the below?? http://drupal.org/node/114774#theme_registry
*/

Perhaps someone familiar with the New hook_theme registry can fininish the conversion, and then this module can be released as ready for 6.4?

The upgraded magic_tabs.module is attached

Thanks.

CommentFileSizeAuthor
#2 drupal6port.patch1.95 KBdawehner
#2 drupal5_tiny_style.patch27 bytesdawehner
magic_tabs.txt6.94 KBjmhead

Comments

yhager’s picture

yhager commented

@jmhead: first, thank you very much for creating this port. I have this on my plans for quite a long time, and I know people are waiting for it - so thank you very much for your effort.

I will look up info about the theme_registry issue, and see if I can find a solution.

One small request: It is rather difficult to review your changes when you attach a full module. Can you create a patch and attach it instead? See http://drupal.org/patch/create for more info.

Again - thank you very much for your work!

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new drupal5_tiny_style.patch27 bytes
new drupal6port.patch1.95 KB

here is a patch
includes also the changed info file
i used the changed drupal5 version with the argument patch
....
Some more stuff... We could write the example code in an extra file -> so less to php to parse

Perhaps we could even separte a lot of functions to a separate .pages.inc file
But this patch does nothing of this instead of a drupal6 version
.....
Here is a small tiny style patch for the d5 version

yhager’s picture

yhager commented
Assigned: Unassigned » yhager

Hey, the port to 6.x seems so trivial, I am ashamed it took so long.. :)
I hope to test this and finish with the last issue during the coming week. Thanks all.

+1 for splitting the example code. What is the purpose of splitting more than that? Anyway, let's keep one bug for an issue, so please open another one on this.

The drupal5_tiny_style.patch on the last comment is empty.

yhager’s picture

yhager commented
Status: Active » Needs work

More work is needed here, cache_* functions have changed, etc.

I am working on it, will update here as soon as I have something.

Babalu’s picture

Babalu commented

subscribing

yhager’s picture

yhager commented
Status: Needs work » Fixed

A first dev release for Drupal 6.x should be available soon here: http://drupal.org/node/317364

Please test it and let me know. New issue for every bug is preferred. If it works for you, please share it here, so I will make an official 6.x release.

Flying Drupalist’s picture

Flying Drupalist commented
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.