Needs review
Project:
Lost & found issues
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Aug 2013 at 12:16 UTC
Updated:
3 Sep 2013 at 08:10 UTC
Jump to comment: Most recent
Currently the tokens will work for 30 days which is a departure from the default in Drupal core of 24 hours. I suggest using the variable user_password_reset_timeout to determine how long links should work and defaulting the value to 24 hours. See #246029: Use a variable for the timeout/expiration of user password reset links (followup) for details on the variable.
Also, if cron stops working on a site then tokens could get old. The query to fetch the token should apply a condition that the token is younger than the variable.
Comments
Comment #1
chrism2671 commentedI agree with this x2, I'll get these in as soon as the initial module gets approved (just trying to get it through first!).
Comment #2
chrism2671 commentedOK I've fixed both of these issues & committed.
Comment #3
gregglesWhich commit(s) fixed this? I did a quick review and didn't see a change that fully addressed this.
Comment #4
chrism2671 commentedHi Greggles,
My mistake- I missed the crucial one; it's in now. I've added a config page, and pulled user_password_reset_timeout in as the default setting as you suggested.