Closed (fixed)
Project:
Logo Tool
Version:
5.x-2.3
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 May 2007 at 14:40 UTC
Updated:
13 Feb 2010 at 17:57 UTC
First, thanks for v2.3 which corrected a lot of issues I encountered (cache pb, wildcard not working...). Only one tiny hitch remains which I was able to correct easily. For each page request, I had a Notice report in my PHP log files concerning a missing index in logo.php line 26. This is due to the fact that a test is made on $_GET['logo'] without an index checking. To correct line 26 of logo.php should be changed from:
$logo = $_GET['logo'] ? $_GET['logo'] : variable_get('logotool_logo', '');
to
$logo = isset($_GET['logo']) ? $_GET['logo'] : variable_get('logotool_logo', '');
Comments
Comment #1
pobster commentedHmmm never realized doing it that way would cause any problems!... Mind you it's not like I've ever read a PHP programming book or had any lessons, I've absolutely no idea of what is good programming practise or not!
...Thanks, I'll change that (and look out for that one in future).
Pobster
Comment #2
pobster commentedClosing off old issues.
Pobster