here is a bugfix for some bugs in the module that fixes the menu system, basepath not added and cleanurls bug. Need to be ported to Drupal5...

CommentFileSizeAuthor
menu_and_url_bugs1.patch3.29 KBhass

Comments

pobster’s picture

Thanks! Nice having a community ;o) Mind you... I've a couple of points;

The menu system; You haven't fixed anything you've just 'pretty-ed' it up into tabs? Nice - I like it, but it wasn't broken? +1 for the tabs though, I prefer that.

The basepath fix; Yes I mentioned this in another thread, I was getting round to that...!

You mention a cleanurls bug; Where have you fixed this? If you're referring to this guy then he never had a problem with the logotool/logos screen (where it shows all the logos) his problem is with the site logo itself which your patch doesn't address? I wouldn't bother looking into this, I'm quite convinced it's some configuration issue.

Pobster

hass’s picture

There was a bug that comes up from the theme i'm using (caused by CSS), while you have created a 4 level of submenus... and drupal have normaly only 3 levels. mores levels are not good for useability (toooo much clicks :-) required). I don't know where, but some weeks ago i found a handbook or comment anywhere on drupal, that told me it's better to use only 3 levels and no more. if you use more, some themes starts to have layout troubles and the user will get troubles with reading the menu items, while they break the line and so on.

for me it was broken :-).

The basepath fix; Yes I mentioned this in another thread, I was getting round to that...!

The SRC to the images is broken without cleanurls... the fix is url('logotool/logo','logo='.$a->basename)

i haven't checked all the modules code... :-). For sure he has the basepath problem and all he have done sound like trying to fix his problem in a very wrong way!

hass’s picture

>The menu system; You haven't fixed anything you've just 'pretty-ed' it up into tabs?
There was a bug that comes up from the theme i'm using (caused by CSS), while you have created a 4 level of submenus... and drupal have normaly only 3 levels. mores levels are not good for useability (toooo much clicks :-) required). I don't know where, but some weeks ago i found a handbook or comment anywhere on drupal, that told me it's better to use only 3 levels and no more. if you use more, some themes starts to have layout troubles and the user will get troubles with reading the menu items, while they break the line and so on.

>Nice - I like it, but it wasn't broken? +1 for the tabs though, I prefer that.
for me it was broken :-).

The basepath fix; Yes I mentioned this in another thread, I was getting round to that...!

>You mention a cleanurls bug; Where have you fixed this?
The SRC to the images is broken without cleanurls... the fix is url('logotool/logo','logo='.$a->basename)

>If you're referring to this guy then he never had a problem with the logotool/logos screen (where it shows all the logos)
>his problem is with the site logo itself which your patch doesn't address? I wouldn't bother looking into this, I'm quite
>convinced it's some configuration issue.
i haven't checked all the modules code... :-). For sure he has the basepath problem and all he have done sound like trying to fix his problem in a very wrong way!

pobster’s picture

Status: Reviewed & tested by the community » Fixed
pobster’s picture

Status: Fixed » Closed (fixed)