Code style fix

CommentFileSizeAuthor
codestyle.diff223.52 KBpodarok

Comments

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Fixed

  • podarok committed f866e0b on 7.x-3.x 
    Issue #2323883 by podarok: Preparing for codesniffer, jshint.

Status: Fixed » Needs work

The last submitted patch, codestyle.diff, failed testing.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs work » Closed (fixed)
nerdcore’s picture

nerdcore commented
Status: Closed (fixed) » Active

Sorry to re-open this issue, but why is `sniffers.sh` included in the latest stable release (7.x-3.7)? It seems to me that code sniff shell scripts aren't usually included with a stable module release.

Are we sure sniffers.sh should be included in this module? And if so, why? I ask because I have not seen such a script in any other module; especially a script which is calling `find` and `phpcs` using `sudo`.

jacob.embree’s picture

jacob.embree commented
Status: Active » Fixed

@nerdcore: The removal of sniffers.sh should be a separate issue. The issue here is about passing codesniffer and jshint which, as of August 20, 2014, was fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.