There are two wrong province names for Argentina in supported/location.ar.inc.

Buenos Aires province should be Buenos Aires and Distrito Federal should be CABA.

CommentFileSizeAuthor
#9 2297529-9.patch1.02 KBrpayanm
#3 location-fix_province_name_argentina-2297529-3.patch1.02 KBtucho
#1 location-fix_province_name_argentina-2297529-1.patch421 bytespancho29

Comments

pancho29’s picture

pancho29 commented
Status: Active » Needs review
StatusFileSize
new location-fix_province_name_argentina-2297529-1.patch421 bytes

the attached patch fixes the issue.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

Thanks francisco@gcoop.coop for making the fix for the same.
This patch looks fine to me and +1 to make it RTBC. Could you please specify some article which is regarding that Distrito Federal should be CABA.

Thanks
Naveen Valecha

tucho’s picture

tucho
Primary language Spanish
Location Buenos Aires
commented
StatusFileSize
new location-fix_province_name_argentina-2297529-3.patch1.02 KB

I just did some spelling corrections.

New patch attached.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

Anyone user from the 'Argentina' could make this one as RTBC that is confirm about the province names ?
Module maintainers,Need your eyes to make this one fixed.

adolfo.mansilla’s picture

adolfo.mansilla commented
Status: Needs review » Reviewed & tested by the community

I am from Argentina. The changes are ok. I move the status to reviewed.

podarok queued 3: location-fix_province_name_argentina-2297529-3.patch for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: location-fix_province_name_argentina-2297529-3.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: +Needs reroll

@tucho,
Patch needs Reroll. would you reroll this patch.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 2297529-9.patch1.02 KB

rerolled

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Reviewed & tested by the community

Thanks! @rpayanm,
Patch seems good and ready to go.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: -Needs reroll

Remove the "Needs reroll" tag after it's rerolled.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Reviewed & tested by the community » Fixed

thanks, commited

  • podarok committed 7a0d181 on 7.x-3.x authored by rpayanm 
    Issue #2297529 by francisco@gcoop.coop, tucho, rpayanm: wrong province...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.