https://github.com/localgovdrupal/localgov_sa11y/issues/8

Issue fork localgov_sa11y-3573175

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

markconroy created an issue. See original summary.

markconroy’s picture

markconroy commented
Version: 1.0.0-beta11 » 1.x-dev
markconroy’s picture

markconroy commented
Issue tags: +DevDaysLGD, +good first issue
joeswarbsbwd’s picture

joeswarbsbwd commented

I'll check this out.

joeswarbsbwd’s picture

joeswarbsbwd commented

Just to check, is the chosen solution just to download and package the files with the module and not defer to Stephen's suggestion on the GitHub?

I started linking the files locally, but struggling to load through the library...

joeswarbsbwd opened merge request !1

joeswarbsbwd’s picture

joeswarbsbwd commented
Status: Active » Needs review

Nevermind, sorted my issue and I've created an MR if that's the route we're still taking - guess the MR can be scrapped if not?

Also I can't add reviewers, so I'll ping this in Slack

markconroy’s picture

markconroy commented
Status: Needs review » Needs work

Just thinking about this @joeswarbsbwd, it might not be okay for us to include 3rd party code inside our module package. It. might have been okay when we were using GitHub and we were in control of what we allowed/disallowed, but Drupal.org does not encourage this pattern.

https://www.drupal.org/docs/develop/git/setting-up-git-for-drupal/drupal...

I think we'd be best to use either composer or Drupal's libraries API to get the assets and then serve them locally.