When I set ListHandler to send attachments as links, it sends attachments. When I set it to attachments, it sends links. This code just looks backwards to me:

      if (variable_get('listhandler_attachments_as_link', 0)) {
        $body .= _listhandler_mail_links($lfiles, $edit['nid'], $fragment);
      }
      else {
        $body = _listhandler_mail_attachments($body, $lfiles, $mid, $fragment);
      }

Is this already fixed in -dev... ?

Comments

cor3huis’s picture

cor3huis commented
Title: Attachment as links vs. in email backwards » Attachment as links vs. in email gives swapped result
Version: 6.x-1.0 » master
Status: Active » Needs review

in Git dev as of 20110131 it is still not changed. Changed therefor the Priority and Status

philipnet’s picture

philipnet commented

Hi,

I've corrected the (logic) error.
It will be fixed in the next -dev release.

philipnet’s picture

philipnet commented
Version: master » 6.x-1.x-dev
Assigned: Unassigned » philipnet
Status: Needs review » Needs work

Please test this in the 6.x-1.x-dev release archive.

cor3huis’s picture

cor3huis commented

Thx GREAT, will test, need to collect all items to test and will then work the issues queue status and info and give feedback. Use Drupal 6.20 on test machine.

Possibly also need to re-make my patches already done for Listhandler against the dev version?

philipnet’s picture

philipnet commented

@cor3huis:
The patches are fine. 'patch' is pretty good at what it does ;)