The function link_validate_url does not support unicode urls. Perhaps it should instead use the inbuilt validate url of drupal?

Comments

Daemon_Byte’s picture

Daemon_Byte commented
Status: Active » Closed (fixed)
Daemon_Byte’s picture

Daemon_Byte commented
Status: Closed (fixed) » Active
steinmb’s picture

steinmb commented

Hi. Think this issue is the same as #733640: Does not allow greek characters in URL though creating a separate patch for every special char in the world is not the way forward.

Daemon_Byte’s picture

Daemon_Byte commented

I don't think so either. I made a patch for my system to allow Swedish and Norwegian characters through which is what I need but I didn't want to post it here as that'd be a bad solution creating a lot of fracture. Not sure if there's an easy way in preg to match unicode.

jcfiala’s picture

jcfiala commented

Does the built in valid_url handle unicode urls? I don't see how it does, from just looking at the code.

Daemon_Byte’s picture

Daemon_Byte commented

No I was wrong on that. I thought it did but it doesn't. Even so if the module is going to only support non unicode urls then it might as well use the inbuilt one. Although it would still be nice to see unicode support given that the module is used by general users if they have a unicode website they're going to want to put it into the system.

jcfiala’s picture

jcfiala commented

Nah, we're not going to use the same one, because it's more limited than what we've got now. For instance, the current module allows mailto and news links, as well as some other protocols, and all valid_url likes is ftp, http (with or without s) and feed urls.

DeeZone’s picture

DeeZone commented
Title: validate function does not allow unicode characters » Chinese example

Like many others in this thread, please put my +1 for support of Unicode characters in the Link module. All of Asia is in need of this functionality or rather all of the non-English world. As an example, http://buy.goodlife.tw/GOMAJI團購麻吉/t/12168/1 produces a "Not a valid URL." validation error when submitting a node with the Link CCK field attached and Chinese in the URL.

steinmb’s picture

steinmb commented
Title: Chinese example » validate function does not allow unicode characters
Category: bug » feature

Pls do not change the issue title, also changing this into an feature req.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Active » Closed (duplicate)
Issue tags: +field validation

Dear followers of this issue: please read the project page info of link module for the further way to go for URL validation issues. There is already an main issue to collect and discuss ALL possible validation scenarios in general. That's why I will mark this one here as duplicate. I need all concentration inside the ONE and only discussion to move forward. After a D7 implementation we will provide a D6 backport.

Explanation: There are too many corner cases and URL validation feature requests of users to implement them all one after the other. We would have a 40 input fields and checkbox lines cluttered settings form for URL validation methods only, conflicting with each other randomly. I think, the better way is to find a maybe more complex but all-embracing new configuration method, which lets the admin better decide, how and when to validate the url. Including a good description which helps to set it up. This will surely lead to a new branch