Problem/Motivation

The webform-lingotek integration resides on webform, not lingotek. We should at least have some tests for ensuring it keeps working.

Proposed resolution

Add tests for the webform module integration.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3193945-webform-tests-2.do-not-test.patch6.76 KBpenyaskito

Issue fork lingotek-3193945

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review

Created MR, as I want to see if that runs the tests with the updated composer.json in contrast with patches, that we know it won't.

penyaskito opened merge request !1

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new 3193945-webform-tests-2.do-not-test.patch6.76 KB

The patch for the record

hlopez’s picture

hlopez commented
Status: Needs review » Reviewed & tested by the community

The tests look great! Thanks!

  • penyaskito committed 0c98efa on 3.5.x 
    Issue #3193945 by penyaskito, hlopez: Add tests for the webform module...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Merged! Thanks!

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.