Give option to append node type to document name when uploading to TMS

1. +++ b/config/install/lingotek.profile.automatic.yml
   @@ -4,6 +4,7 @@ weight: 30
   +append_type_to_title: false
   

   If we would like to ignore it by default, we would need to write an upgrade path that sets this as TRUE, so existing users don't see a change in the current behavior. That will need tests too.

2. +++ b/config/schema/lingotek.schema.yml
   @@ -39,6 +39,9 @@ lingotek.settings:
   +        title_append_type:
   +          label: 'Global setting to set whether to append content type to title in TMS'
   +          type: string
   
   @@ -256,6 +259,9 @@ lingotek.profile.*:
   +    append_type_to_title:
   +      type: boolean
   +      label: 'Append Content Type To Title'
   

   These are inconsistent. Let's use the same name and type.

3. +++ b/src/Form/LingotekSettingsTabPreferencesForm.php
   @@ -153,6 +153,20 @@ class LingotekSettingsTabPreferencesForm extends LingotekConfigFormBase {
   +    $options = array(
   +      'always' => t('Always append regardless of profile setting'),
   +      'never' => t('Never append regardless of profile setting'),
   +      'profile' => t('Use profile setting (for editable profiles only)'),
   +    );
   

   I'm not sure if this is a UX pattern we want to follow, because it would be the first time. Usually we have a setting, and the profile can override that.

   For me the options would be "Use default settings", "no", "yes".

4. +++ b/src/LingotekConfigTranslationService.php
   @@ -366,7 +366,23 @@ class LingotekConfigTranslationService implements LingotekConfigTranslationServi
   +    $lingotek_config = \Drupal::service('lingotek.configuration');
   

   Isn't this service already injected?

5. +++ b/src/LingotekConfigTranslationService.php
   @@ -416,7 +432,23 @@ class LingotekConfigTranslationService implements LingotekConfigTranslationServi
   +    $lingotek_config = \Drupal::service('lingotek.configuration');
   

   Isn't this service already injected?

6. +++ b/src/LingotekContentTranslationService.php
   @@ -718,9 +718,25 @@ class LingotekContentTranslationService implements LingotekContentTranslationSer
   -    $profile = $this->lingotekConfiguration->getEntityProfile($entity);
   

   If this is unrelated let's leave it there.

7. +++ b/src/LingotekContentTranslationService.php
   @@ -1224,7 +1255,7 @@ class LingotekContentTranslationService implements LingotekContentTranslationSer
   +        $data['_lingotek_metadata']['_intelligence']['content_type'] = $entity->getEntityTypeId() . ' - ' . $entity->bundle();
   

   Are we sure we want to do this, instead of having an extra metadata key?

8. +++ b/tests/src/Functional/LingotekNodeTranslationDownloadStatusTest.php
   @@ -82,6 +82,7 @@ class LingotekNodeTranslationDownloadStatusTest extends LingotekTestBase {
   +    $this->drupalGet('admin/lingotek/settings');
   
   @@ -102,6 +103,7 @@ class LingotekNodeTranslationDownloadStatusTest extends LingotekTestBase {
   +    $this->drupalGet('admin/lingotek/settings');
   
   @@ -122,6 +124,7 @@ class LingotekNodeTranslationDownloadStatusTest extends LingotekTestBase {
   +    $this->drupalGet('admin/lingotek/settings');
   
   @@ -142,6 +145,7 @@ class LingotekNodeTranslationDownloadStatusTest extends LingotekTestBase {
   +    $this->drupalGet('admin/lingotek/settings');
   

   Why is this necessary?

+++ b/src/Form/LingotekProfileFormBase.php
@@ -105,6 +105,23 @@ class LingotekProfileFormBase extends EntityForm {
+    $options = array(
+      'global_setting' => 'Use global setting',
+      'yes' => 'Yes',
+      'no' => 'No',
+    );

The keys don't, but the values need to be passed through $this->t()

Updated hook_update_N after latest commits.
Fixed precedent comment.
Fixed some comment standards.

Tests are green, and looks like there's coverage for the upgrade path. Not sure if there are enough tests for when the option is false, or overridden in the profile, but I think it's good.

Thanks!

Added tests for the options themselves.

Tests passed as expected. Thanks Edward!

Committed f6bf4ac and pushed to 8.x-2.x. Thanks!