Problem/Motivation

Users need to go to Lingotek settings after editing Language Content Settings for setting up Lingotek translation.

Proposed resolution

Save same settings per Lingotek as they are saved for Language Content Settings.

Remaining tasks

Discuss if this is what we want.

User interface changes

Added a checkbox in Language Content Settings for saving same settings as Lingotek translation settings.

API changes

None

Data model changes

None

Original report:

Problem / Motivation
LingoTek field configuration happens outside of the field instance
configuration page, this can cause a problem when the data model is been created
because they might forget to reconfigure Lingotek translation configuration.
Possible solution
I believe that the LingoTek configuration should be on the same page
as the field instance page. The profile configuration can be set at the content type level.

CommentFileSizeAuthor
#16 allow_drupal_core_settings_import-2890529-18.patch6.26 KBmdahl328151
#15 allow_drupal_core_settings_import-2890529-15.patch2.44 KBmdahl328151
#12 allow_drupal_core_settings_import-2890529-13.patch2.35 KBmdahl328151
#9 allow_drupal_core_settings_import-2890529-7.patch7.14 KBmdahl328151
#6 allow_drupal_core_settings_import-2890529-6.patch8.75 KBmdahl328151
#3 allow_drupal_core_settings_import-2890529-5.patch5.05 KBmdahl328151
#2 allow_drupal_core_settings_import-2890529-3.patch4.28 KBmdahl328151

Comments

mdahl328151 created an issue. See original summary.

mdahl328151’s picture

mdahl328151 commented
StatusFileSize
new allow_drupal_core_settings_import-2890529-3.patch4.28 KB
mdahl328151’s picture

mdahl328151 commented
StatusFileSize
new allow_drupal_core_settings_import-2890529-5.patch5.05 KB
mdahl328151’s picture

mdahl328151 commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: allow_drupal_core_settings_import-2890529-5.patch, failed testing. View results

mdahl328151’s picture

mdahl328151 commented
StatusFileSize
new allow_drupal_core_settings_import-2890529-6.patch8.75 KB
mdahl328151’s picture

mdahl328151 commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: allow_drupal_core_settings_import-2890529-6.patch, failed testing. View results

mdahl328151’s picture

mdahl328151 commented
StatusFileSize
new allow_drupal_core_settings_import-2890529-7.patch7.14 KB
mdahl328151’s picture

mdahl328151 commented
Status: Needs work » Needs review
mdahl328151’s picture

mdahl328151 commented
Assigned: Unassigned » mdahl328151
mdahl328151’s picture

mdahl328151 commented
StatusFileSize
new allow_drupal_core_settings_import-2890529-13.patch2.35 KB

Status: Needs review » Needs work

The last submitted patch, 12: allow_drupal_core_settings_import-2890529-13.patch, failed testing. View results

mdahl328151’s picture

mdahl328151 commented 
+++ b/lingotek.module
@@ -480,4 +480,49 @@ function lingotek_form_language_admin_edit_form_alter(&$form, FormStateInterface
+            if (isset($$bundleInfo['fields'][$field_id . ':properties'])) {

There is a syntax error that is making this test fail

mdahl328151’s picture

mdahl328151 commented
Status: Needs work » Needs review
StatusFileSize
new allow_drupal_core_settings_import-2890529-15.patch2.44 KB
mdahl328151’s picture

mdahl328151 commented
StatusFileSize
new allow_drupal_core_settings_import-2890529-18.patch6.26 KB
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Can we post a screenshot of this settings page after the patch is applied?

I think it can really risk usability on that page.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Sorry I misunderstood this, thanks for working on that!

I tested this and I understand now. We are not modifying the form itself, but when submitted we update Lingotek translation settings accordingly to what's setup in Content Language Settings.

The problem here is my experience says that this can be quite different. E.g., sane default setting for node "Publishing status" is translatable, but we probably never want to use Lingotek for that field. I'm in favor of sane defaults, but not sure if just copying those from Content Translation Settings is a good idea.

Also, from my testing looks like subproperties are not working well (e.g. Image alt text)

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Title: Allow Drupal Core entity translation settings into Lingotek Content Settings » When saving content language settings store the same settings as Lingotek settings
Issue summary: View changes
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Closed (won't fix)

Instead of assuming Language content settings are valid as Lingotek settings, which may not be the case in most cases, let's do #2899880: Provide better defaults in Lingotek language settings instead.