update.sh doesn't really update?

Since you've seen the make file, then its likely you understand that we have a LOT of patches going into Lightning Features.

If you download the package, you're getting the latest versions of whatever we pointed to in the make file.

The update.sh should be run in order to stay current with Lightning Features' requirements.

It is not run to somehow magically get every module into a "green" stable state without patches or automagically do a security update.

Nor does it update lightnng_features itself. That's up to you to do before you run update.sh

An example flow would be.

On Oct 20th I downloaded Lightning

On Oct 22nd the lightning_features.make file was updated. Lets say a new version of Views.

On Oct 23rd I discovered this, so I replaced my existing lightning_features folder with the newest version. Then I run update.sh and the make file runs, updating the code for any modules. In this case, I get a new version of Views.

Does that make sense? If I am missing something, let me know. There may have been something in the readme that lead to this confusion, so we can definitely work together to rephrase that at the very least.

That said, a Feature request could be: Lightning Features update.sh should also update lightning_features in addition to updating the contrib.

I did update the README.md after reviewing it. It was not clear that you needed to first replace the existing lightning_features module to get a newer make file.

@greggmarshall lmk if this is clearer now. Thanks for the report!

See: http://cgit.drupalcode.org/lightning_features/commit/?id=f66860b