Hi there, I'd like to offer my services as a co-maintainer for this module. I currently maintain the following projects:
Support Views and Portal Theme. I attach a patch which fixes the default zoom issue by making this a configuration value in the settings form, which adds descriptions to the fields in the admin interface and which increases the maximum zoom level from 17 to 19 which is MapBox's max zoom.

CommentFileSizeAuthor
leaflet_mapbox-multifix.patch2.53 KBHomotechsual

Comments

jherencia’s picture

jherencia commented
Status: Active » Closed (won't fix)

Well, thank you for the offer, I can handle this by myself but would have this in mind in the future if I have no time.

Anyway, I've found this issues in your patch:

  • your patch does not follow Drupal coding standards (https://drupal.org/coding-standards)
  • you added a new variable and didn't delete it in hook_uninstall
  • you added credit to yourself in any map
+++ b/leaflet_mapbox.moduleundefined
@@ -51,7 +52,7 @@ function leaflet_mapbox_leaflet_map_info() {
-        'options' => array('attribution' => '')
+        'options' => array('attribution' => 'Design by <a href="http://mjco.ltd.uk" title="MJCO Limited">MJCO</a>')

Thank you.

Homotechsual’s picture

Homotechsual commented

DOH!

I read in another issue that you've used parts of the patch to fix the zoom options. So I'll reroll the patch according to coding standards and without that change (which got copied in from the site I'm using the module on).

I've also made 'custom icons' work by adding these as settings so I'll include those in the patch so you can take a look.

MJCO