String comparison fails when the dn_attribute specified in the admin UI differs from that which the LDAP directory uses. For example, in our Active Directory, it's "OU". Propose the attached patch.

CommentFileSizeAuthor
ldapgroups_module.patch214 byteskassissieh

Comments

johnbarclay’s picture

johnbarclay commented

My feeling is that all the strings in ldap integration should be case insensitive. I believe some of the ldap functions in php are case insensitive so it would help with consistency.

You should use drupal_strtolower rather than strtolower. I believe this convention is for internationalization or unicode issues, but can't remember why the convention is used.

the standard format for drupal patches is

cvs diff -up > example.patch

and the details are at:

http://drupal.org/patch/create

miglius’s picture

miglius commented
Status: Active » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.