Hello,

_ldagroups_detect_groups() is better to get the user from a parameter. That way it could be used in different circumstances, and follow the same logic of other functions (ldapgroups_user_login() gets its user from a parameter for example).

CommentFileSizeAuthor
ldapgroups_params.patch1 KBAmrMostafa

Comments

kreaper’s picture

kreaper commented
Assigned: Unassigned » kreaper

Scafmac

I do not see a problem with this. Do you ?

kreaper

kreaper’s picture

kreaper commented
Status: Needs review » Closed (fixed)

patch applied to HEAD.