Fix failing tests

Problem/Motivation

There was 1 PHPUnit error:

1) Drupal\Tests\ldap_user\Unit\ProtectedUserFieldConstraintValidatorTest::testValidate
The data provider specified for Drupal\Tests\ldap_user\Unit\ProtectedUserFieldConstraintValidatorTest::testValidate is invalid
Data Provider method Drupal\Tests\ldap_user\Unit\ProtectedUserFieldConstraintValidatorTest::providerTestValidate() is not static

/var/www/html/ldap_user/tests/src/Unit/ProtectedUserFieldConstraintValidatorTest.php:66

--

There were 4 errors:

1) Drupal\Tests\ldap_servers\Unit\Form\LdapDebugSettingsTest::testGetFormId
Symfony\Component\DependencyInjection\Exception\AutowiringFailedException: Cannot autowire service "Drupal\Core\Config\ConfigFactoryInterface": argument "$config_factory" of method "Drupal\ldap_servers\Form\LdapDebugSettings::__construct()". Check that either the argument type is correct or the Autowire attribute is passed a valid identifier. Otherwise configure its value explicitly if possible.

/var/www/html/web/core/lib/Drupal/Core/DependencyInjection/AutowiredInstanceTrait.php:90
/var/www/html/web/core/lib/Drupal/Core/DependencyInjection/AutowiredInstanceTrait.php:32
/var/www/html/web/core/lib/Drupal/Core/DependencyInjection/AutowireTrait.php:26
/var/www/html/ldap_servers/tests/src/Unit/Form/LdapDebugSettingsTest.php:66

2) Drupal\Tests\ldap_servers\Unit\Form\LdapDebugSettingsTest::testBuildForm
Symfony\Component\DependencyInjection\Exception\AutowiringFailedException: Cannot autowire service "Drupal\Core\Config\ConfigFactoryInterface": argument "$config_factory" of method "Drupal\ldap_servers\Form\LdapDebugSettings::__construct()". Check that either the argument type is correct or the Autowire attribute is passed a valid identifier. Otherwise configure its value explicitly if possible.

/var/www/html/web/core/lib/Drupal/Core/DependencyInjection/AutowiredInstanceTrait.php:90
/var/www/html/web/core/lib/Drupal/Core/DependencyInjection/AutowiredInstanceTrait.php:32
/var/www/html/web/core/lib/Drupal/Core/DependencyInjection/AutowireTrait.php:26
/var/www/html/ldap_servers/tests/src/Unit/Form/LdapDebugSettingsTest.php:66

3) Drupal\Tests\ldap_servers\Unit\Form\LdapDebugSettingsTest::testSubmitForm
Symfony\Component\DependencyInjection\Exception\AutowiringFailedException: Cannot autowire service "Drupal\Core\Config\ConfigFactoryInterface": argument "$config_factory" of method "Drupal\ldap_servers\Form\LdapDebugSettings::__construct()". Check that either the argument type is correct or the Autowire attribute is passed a valid identifier. Otherwise configure its value explicitly if possible.

/var/www/html/web/core/lib/Drupal/Core/DependencyInjection/AutowiredInstanceTrait.php:90
/var/www/html/web/core/lib/Drupal/Core/DependencyInjection/AutowiredInstanceTrait.php:32
/var/www/html/web/core/lib/Drupal/Core/DependencyInjection/AutowireTrait.php:26
/var/www/html/ldap_servers/tests/src/Unit/Form/LdapDebugSettingsTest.php:66

4) Drupal\ldap_servers\Tests\Unit\ServerListBuilderTest::testGetOperations
Error: Call to a member function isAllowed() on null

/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:172
/var/www/html/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityListBuilder.php:43
/var/www/html/ldap_servers/src/ServerListBuilder.php:153
/var/www/html/ldap_servers/tests/src/Unit/ServerListBuilderTest.php:257

--

There were 3 failures:

1) Drupal\ldap_servers\Tests\Unit\ServerListBuilderTest::testBuildRowServiceAccountBindFailure
Drupal\Core\Entity\EntityBase::label() was not expected to be called more than once.

/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:165
/var/www/html/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityListBuilder.php:43
/var/www/html/ldap_servers/src/ServerListBuilder.php:153
/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:278
/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:259
/var/www/html/ldap_servers/src/ServerListBuilder.php:112
/var/www/html/ldap_servers/tests/src/Unit/ServerListBuilderTest.php:231

2) Drupal\ldap_servers\Tests\Unit\ServerListBuilderTest::testBuildRowServiceAccount
Drupal\Core\Entity\EntityBase::label() was not expected to be called more than once.

/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:165
/var/www/html/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityListBuilder.php:43
/var/www/html/ldap_servers/src/ServerListBuilder.php:153
/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:278
/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:259
/var/www/html/ldap_servers/src/ServerListBuilder.php:112
/var/www/html/ldap_servers/tests/src/Unit/ServerListBuilderTest.php:166

3) Drupal\ldap_servers\Tests\Unit\ServerListBuilderTest::testBuildRow
Drupal\Core\Entity\EntityBase::label() was not expected to be called more than once.

/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:165
/var/www/html/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityListBuilder.php:43
/var/www/html/ldap_servers/src/ServerListBuilder.php:153
/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:278
/var/www/html/web/core/lib/Drupal/Core/Entity/EntityListBuilder.php:259
/var/www/html/ldap_servers/src/ServerListBuilder.php:112
/var/www/html/ldap_servers/tests/src/Unit/ServerListBuilderTest.php:110

--

There were 2 risky tests:

1) Drupal\Tests\ldap_authentication\Unit\ModuleTest::testUserLoginBlockAlter
This test did not perform any assertions

/var/www/html/ldap_authentication/tests/src/Unit/ModuleTest.php:562

2) Drupal\Tests\ldap_authentication\Unit\Plugin\Derivative\DynamicUserHelpLinkTest::testCreate
This test did not perform any assertions

/var/www/html/ldap_authentication/tests/src/Unit/Plugin/Derivative/DynamicUserHelpLinkTest.php:91

ERRORS!
Tests: 259, Assertions: 1265, Errors: 5, Failures: 3, Warnings: 1, PHPUnit Deprecations: 82, Risky: 2.

Debug Report

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes