We need to add the CKEditor in a details box. Due to some specific CSS the editor is nested incorrectly. I attached a screenshot of the issue. The CSS in question is
"#layout-builder-modal details div {
padding: 0 1.5em 1em 1.5em;
}"
I believe it should be
"#layout-builder-modal details > div {
padding: 0 1.5em 1em 1.5em;
}"
I will work on getting a patch out there.

CommentFileSizeAuthor
#6 layout_builder_modal-fix-ckeditor-in-details-3096039.patch1.34 KBmsauber28
Details CKEditor.png63.96 KBmsauber28

Comments

msauber28 created an issue. See original summary.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

Thanks for reporting this. Can you indicate which version of Drupal core you're testing this against? Changes between Drupal 8.7.x, 8.8.0-alpha1, and 8.8.0-beta1 relating to the Media Library and also CKEditor may account for an introduction of a CSS change; if so, we'd need to ensure that the change also indicates which version(s) of Drupal core it's designed for.

Additionally, ideally, we'd want the patch to replicate the CSS that is provided by Drupal core's "Seven" module, rather than just fixing this observed visual discrepancy.

See https://www.drupal.org/project/drupal/releases/8.8.0-beta1

msauber28’s picture

msauber28 commented

I'm using 8.7.10. I'm not seeing what CSS you are talking about in the seven module. Do you know where it is?

msauber28’s picture

msauber28 commented
Title: CKeditor in Details box is Not displaying correctly » CKEditor in Details box is Not displaying correctly
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

Based on inline comments in https://git.drupalcode.org/project/layout_builder_modal/blob/8.x-1.x/the..., it looks like what Layout Builder Modal is using is a modification of https://github.com/drupal/drupal/blob/8.8.x/core/themes/seven/css/compon..., since the `.seven-details` class is not present.

So, I think we want to follow suit with Drupal core by adding this: https://github.com/drupal/drupal/blob/8.8.x/core/themes/seven/css/compon... (again, renamed for use outside of the context of Seven.

msauber28’s picture

msauber28 commented
StatusFileSize
new layout_builder_modal-fix-ckeditor-in-details-3096039.patch1.34 KB

Here is a patch to fix the issue and it follows the seven theme example

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Reviewed & tested by the community

Implementation looks good to me. I'll leave this a RTBC for a day or two for other maintainers to look at, and after that plan to commit it.

msauber28’s picture

msauber28 commented

It’s been a couple days. Are we good to commit?

  • mark_fullmer committed 5cbcedf on 8.x-1.x 
    Issue #3096039 by msauber28, mark_fullmer, Dave Reid: CKEditor in...
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Reviewed & tested by the community » Fixed

Yes, thanks. Committed & credited! I'll discuss with the other maintainers whether it's time to do a new release.

matt_paz’s picture

matt_paz commented

I just tested this (latest dev) on 8.8.0 and was unable to get it to work. Is is confirmed/expected to work on 8.8.0?
Never mind. I just re-tested on bartik w/out lb_modal, and I wasn't able to get CK Editor to load, so I've got something else going on.

Apologies for the misattribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.