Update the dependency for Hook events dispatcher from 1.x to 2.x for better D9 support.

D9 wants the 2.x branch of the hooks event dispatcher so in order to upgrade an existing 8.9.2 drupal to 9 (that uses layout builder kit)

we need to change the dependency on the composer.json of the module.

Comments

kalmanos created an issue. See original summary.

sonameu’s picture

sonameu commented
Issue summary: View changes
aangel’s picture

aangel commented

Are others seeing any side effects from upgrading to 2.x that you've seen? Have you tried updating it to 2.x locally and tried it?

sonameu’s picture

sonameu commented

Hey aangel, everything seems to be ok in a local enviroment. At least from a layout builder perspective.
Maybe we could create a 2.x branch for the layout builder library with the change in dependencies.
What's your opinion?

aangel’s picture

aangel commented

Ok, I'll try it, too...I'd like to reserve creating a new branch for something more consequential than this.

sonameu’s picture

sonameu commented

Yeap i get what you are saying. I agree with creating a new branch for something more consequential than this.
Let's leave it as it is for now i guess. Thanks for your time.

aangel’s picture

aangel commented

We are making the changes for HED 2.x and will push them into -dev for people to test. The possible problem is if people are using HED for their own purposes (outside of LBK) then upgrading to the latest beta of LBK will force them to upgrade their custom code to use the HED 2.x branch. We may have to put a note telling people to lock their LBK to the current version until they have the time to upgrade their custom code to HED 2.x. The upgrade seems worth it, though, as it should reduce the memory footprint nicely.

Would be be able to test the -dev version on your site when it's ready? Should be ready by the weekend and it would be helpful to have someone outside our shop testing.

aangel’s picture

aangel commented
Status: Active » Fixed

Branch is now old; moving to the 2.x branch, which required HED 3.x.

aangel’s picture

aangel commented
Status: Fixed » Closed (fixed)