Problem/Motivation

PHP 8.4 deprecated implicitly defining parameters as null ie (Request $request = NULL).
2.0.x-dev has fixed this in the main code but one remains in the language_cookie_test module.

Steps to reproduce

Install the phpcompatibility standard for phpcs:
composer require phpcompatibility/php-compatibility
Run phpcs with the phpcompatibility standard against 8.4:
vendor/bin/phpcs -p --standard=PHPCompatibility --runtime-set testVersion 8.4 -d memory_limit=-1
Note deprecation.

Proposed resolution

Explicitly define the parameter as nullable, ie `(?Request $request = NULL)`

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork language_cookie-3567354

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cchiste created an issue. See original summary.

cchiste’s picture

cchiste commented
Status: Active » Needs review
cchiste’s picture

cchiste commented
Title: Explicitly type hint nullable $request in test module » PHP 8.4: Explicitly type hint nullable $request in test module
Assigned: cchiste » Unassigned

cchiste opened merge request !15

  • jeroent committed 25e1203f on 2.0.x authored by cchiste 
    feat: #3567354 PHP 8.4: Explicitly type hint nullable $request in test...
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Fixed

Merged to 2.0.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.