Issues found in landing page configuration.

  • In the configuration form of landing page(admin/config/content/landing-pages), the path is not showing there after clicking the 'Re-scan template files' - button.
  • Also the description of the textbox shows the naming of the tpl file, not the twig.

I have attached the screenshot of the issues.

Landing page configuration

CommentFileSizeAuthor
#5 path_not_showing-2818255-4.patch1.6 KBmagi.yv
#3 path_not_showing-2818255-2.patch1.91 KBmagi.yv
#3 path_not_showing-2818255-2.patch1.91 KBmagi.yv
landing-page-configuration.png48.11 KBakhilavnair

Comments

akhilavnair_zyxware created an issue. See original summary.

magi.yv’s picture

magi.yv commented
Assigned: Unassigned » magi.yv
magi.yv’s picture

magi.yv commented
Assigned: magi.yv » Unassigned
Status: Needs work » Needs review
StatusFileSize
new path_not_showing-2818255-2.patch1.91 KB
new path_not_showing-2818255-2.patch1.91 KB

@ Akhila

Please try the patch 'path_not_showing-2818255-2.patch'

akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
commented
Status: Needs review » Reviewed & tested by the community

Hi magi.yv,

The patch from #3 is working for me.

Thanks for the patch.

Note that, the function doc comment for hook_theme_suggestions_HOOK_alter (landing_page_theme_suggestions_page_alter) is incorrect in landing_page.module file.
Please change this.

Also here you attached path_not_showing-2818255-2_0.patch and path_not_showing-2818255-2_1.patch, both seems same. So I'm hiding path_not_showing-2818255-2_1.patch from the issue.

magi.yv’s picture

magi.yv commented
Assigned: Unassigned » magi.yv
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new path_not_showing-2818255-4.patch1.6 KB

Hi Akhila,

Thank you for the review. Removed the mentioned doc comment from review, it is not related with this issue.
Please check the latest patch.

magi.yv’s picture

magi.yv commented
Assigned: magi.yv » Unassigned
Status: Needs work » Needs review
akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
commented
Status: Needs review » Reviewed & tested by the community

Hi magi.yv,

Patch from the comment #5 is working well.
Thanks for the patch.

mslabba_zyxware’s picture

mslabba_zyxware commented
Status: Reviewed & tested by the community » Fixed

Successfully merged the patch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.