Problem/Motivation

Scanning the module with phpstan or Upgrade Status results in,

Method Drupal\key\Controller\KeyListBuilder::getOperations() is missing the CacheableMetadata parameter added in Drupal 11.3. Update the signature to: getOperations(\Drupal\Core\Entity\EntityInterface $entity, ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).

Proposed resolution

Add the parameter.

CommentFileSizeAuthor
#4 d12-key75-02.png47.09 KBrajab natshah
#4 d12-key75-01.png44.19 KBrajab natshah

Issue fork key-3627461

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !75

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review
rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new d12-key75-01.png44.19 KB
new d12-key75-02.png47.09 KB

Tested !75 on key 1.22 (with !34 from #3484086) on Drupal 11.4.8 and 12.0.0-beta1 (PHP 8.5): the key list and operations work on both, and the getOperations() fatal on 12 is gone. The red phpstan job is about files this MR does not touch. Looks good to me.

Screenshot

Screenshot

benstallings’s picture

benstallings commented
Status: Needs review » Reviewed & tested by the community
ptmkenny’s picture

ptmkenny commented
Status: Reviewed & tested by the community » Needs review

@benstallings I don't think you should set RTBC on your own issue. If someone else gave a review but did not set RTBC, it could mean they forgot, but it could also mean that they did a review but they don't feel confident to mark RTBC.