Closed (fixed)
Project:
Key
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
10 Aug 2016 at 13:44 UTC
Updated:
10 Sep 2026 at 14:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
talhaparacha commentedI also think that this is a very valid issue. Here is a patch that attempts to fix it by providing a confirmation checkbox on the key edit form. This makes editing a key entity a bit harder while also warning the user about the possible consequences of a key edit.
This is consistent with the edit form for an Encryption Profile provided by Encrypt module.
Comment #3
talhaparacha commentedSame as #2, with testing enabled this time :p
Comment #4
rlhawkI agree that we need to do more to warn users about the possible negative consequences of editing a key. I'm not crazy about the way Encrypt handles the editing of Encryption Profiles, so I'm hesitant to adopt that pattern for Key. What if instead we had a confirmation page that added the warning and required users to click to confirm—just as they are required to do when deleting a key, which is an action with consequences that are potentially more severe?
Comment #5
rlhawkComment #6
rlhawkHere's a fresh patch that implements the same sort of edit confirmation form that Encrypt now uses.
Comment #7
tynor commentedPatch on #6 looks good to me.
Comment #9
rlhawkComment #11
attheshow commentedJust in case there's anyone else out there like us that wants to be able to skip the confirmation step and edit the key values more quickly/easily, here's a simple patch that allows that. 😊