Dependent modules usually require consistency in key settings. So changing key values or other attributes will break things.

We should either add a big warning on the key edit page or add an "Are you sure?" page on submit (or both).

The other option is too make all of these settings read-only after each instance is created.

Comments

colan created an issue. See original summary.

talhaparacha’s picture

StatusFileSize
new2.12 KB
new27.08 KB

I also think that this is a very valid issue. Here is a patch that attempts to fix it by providing a confirmation checkbox on the key edit form. This makes editing a key entity a bit harder while also warning the user about the possible consequences of a key edit.

Only local images are allowed.

This is consistent with the edit form for an Encryption Profile provided by Encrypt module.

talhaparacha’s picture

Status: Active » Needs review
StatusFileSize
new2.12 KB

Same as #2, with testing enabled this time :p

rlhawk’s picture

I agree that we need to do more to warn users about the possible negative consequences of editing a key. I'm not crazy about the way Encrypt handles the editing of Encryption Profiles, so I'm hesitant to adopt that pattern for Key. What if instead we had a confirmation page that added the warning and required users to click to confirm—just as they are required to do when deleting a key, which is an action with consequences that are potentially more severe?

rlhawk’s picture

Status: Needs review » Needs work
rlhawk’s picture

Status: Needs work » Needs review
StatusFileSize
new2.84 KB

Here's a fresh patch that implements the same sort of edit confirmation form that Encrypt now uses.

tynor’s picture

Status: Needs review » Reviewed & tested by the community

Patch on #6 looks good to me.

  • rlhawk committed 13cccae on 8.x-1.x
    Issue #2782061 by talhaparacha, rlhawk: Prevent key settings from being...
rlhawk’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

attheshow’s picture

StatusFileSize
new346 bytes

Just in case there's anyone else out there like us that wants to be able to skip the confirmation step and edit the key values more quickly/easily, here's a simple patch that allows that. 😊