Make visible two different blocks of aggregator content, and make both of them load dynamically.
You'll notice that only one row is created in the DB. (module: aggregator)

Seems like it's overwriting the other block's row.

Let me know if you need further explanation.

i.e. If the 2 blocks is of the same module, they will overwrite each other's settings

CommentFileSizeAuthor
#5 temp.jpg759.92 KBjacauc

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Title: Separate rows in DB should be created for blocks of the same module » Error in SQL for saving block settings
Assigned: Unassigned » nedjo
Status: Active » Fixed

Every module developer should have so thorough a bug reporter as you! (Or, maybe I should say, every module developer who, like me, seems to have the habit of committing changes before testing them....)

I'd missed part of the needed change in SQL, now fixed.

jacauc’s picture

jacauc commented

ROFL! Well, as long as you keep fixing them, I'll keep looking for more :P
Been waiting for this functionality for a loooong, time, so to finally have it is great.... That's why I wanna make sure all works like it should.

Thanks again for the quick fix!
jacauc

jacauc’s picture

jacauc commented
Title: Error in SQL for saving block settings » Blocks overwriting other block's settings
Status: Fixed » Active

Still not fixed.
What I am referring to, is that if I look in the "blocks" table for aggregator module rows, the "delta" value for that block is not an integer. Usually something like "feed-9".

But in the dynamicload table, the aggregator block gets saved with a "delta" value of 0

In other words, when the next aggregator block is saved, it overwrites the same row in the DB

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

I can't reproduce this. I've tested with two blocks from user.module and they both get saved correctly (two rows in the db). I've also reviewed the code and it correctly tests for unique module-delta combinations.

Please try again with the current HEAD code.

jacauc’s picture

jacauc commented
StatusFileSize
new temp.jpg759.92 KB

Sorry for only getting back to you now. Somehow lost track of this.

I've attached a zipfile with some screenshots. (just rename it from temp.jpg to temp.zip - can't upload zipfiles)
Using HEAD code, but it's still happening

jacauc

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Fixed

I think this is fixed, can't reproduce the issue.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)