Hi,

I'm using tabs in a block as well as on a page. They seem to interfere with each other if I am on the tabbed page with the tabbed block at the same time. The tabs stop working on the page and the tabbed block display s the content of two tabs. Any ideas?

Thanks,

Jim

CommentFileSizeAuthor
#3 tabs-multiple.patch2.39 KBnedjo

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks for pointing this out. We need to look at the HTML we're generating and the code in tabs.js in comparison to http://www.stilbuero.de/jquery/tabs/ to see what's wrong.

jwilde’s picture

jwilde commented

Thanks Nedjo, let me know if I can help test anything out.

jim

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Fixed
StatusFileSize
new tabs-multiple.patch2.39 KB

Fixed with the attached patch, applied to trunk/head. (I'll merge soon into the 5.x branch.)

I introduced a required #name attribute for a tabset, used to avoid conflicts (and also, likely, to allow scripts to identify tabsets by id). You'll need to change the way you generate tabs (look at the example in the module code).

jwilde’s picture

jwilde commented
Status: Fixed » Closed (fixed)

New version works great - thank you!

jim

joshk’s picture

joshk commented

Nedjo ++

Thanks!

discursives’s picture

discursives commented

will this be committed?