Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#13 jsonapi_views-drupal10-compatibility-3288151-13.patch1.86 KBe.bogatyrev
#10 jsonapi_views-3288151-9.patch6.81 KBdeciphered
#7 interdiff_3-7.txt721 bytesreenaraghavan
#7 jsonapi_views-3288151-7.patch5.99 KBreenaraghavan
#3 jsonapi_views.1.x-dev.rector.patch5.09 KBproject update bot
#3 interdiff-last-bot.6643698.txt350 bytesproject update bot
#2 jsonapi_views.1.x-dev.rector.patch4.84 KBproject update bot

Issue fork jsonapi_views-3288151

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new jsonapi_views.1.x-dev.rector.patch4.84 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6643698.txt350 bytes
new jsonapi_views.1.x-dev.rector.patch5.09 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1

Status: Needs review » Needs work

The last submitted patch, 3: jsonapi_views.1.x-dev.rector.patch, failed testing. View results

project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

reenaraghavan made their first commit to this issue’s fork.

reenaraghavan’s picture

reenaraghavan commented
Issue summary: View changes
StatusFileSize
new jsonapi_views-3288151-7.patch5.99 KB
new interdiff_3-7.txt721 bytes

abhinesh made their first commit to this issue’s fork.

Deciphered made their first commit to this issue’s fork.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new jsonapi_views-3288151-9.patch6.81 KB

Updated MR and Patch, should now be passing tests.

Deciphered opened merge request !9

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Needs work

It appears that the JSON:API Views exposed sorts provides a different result in Drupal 10, causing the tests to fail.

Further investigation / work required.

e.bogatyrev’s picture

e.bogatyrev
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new jsonapi_views-drupal10-compatibility-3288151-13.patch1.86 KB

Hi everyone,

I checked out the branch 3288151-automated-drupal-10, verified compatibility and discovered the following after scanning issues by the upgrade_status module
drush upgrade_status:analyze jsonapi_views

================================================================================
JSON:API Views, --
Scanned on Fri, 02/10/2023 - 01:52

FILE: web/modules/contrib/jsonapi_views/jsonapi_views.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8.8 || ^9 || ^10 is not
                    compatible with the next major version of Drupal core. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/jsonapi_views/tests/modules/jsonapi_views_test/jsonapi_views
_test.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8.8 || ^9 || ^10 is not
                    compatible with the next major version of Drupal core. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/jsonapi_views/composer.json

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    The drupal/core requirement is not compatible with the next
                    major version of Drupal. Either remove it or update it to be
                    compatible. See
                    https://drupal.org/node/2514612#s-drupal-9-compatibility.
--------------------------------------------------------------------------------

Apart from this I verified the tests. The issue is related to missed parameter (field_identifier: nid) in test view views.view.jsonapi_views_test_node_view.yml

After applying the patch

Compatibility check

================================================================================
JSON:API Views, --
Scanned on Fri, 02/10/2023 - 01:54

No known issues found.

Tests run

PHPUnit 9.6.3 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\jsonapi_views\Functional\JsonapiViewsResourceTest
......                                                              6 / 6 (100%)

Time: 01:40.078, Memory: 10.00 MB

OK (6 tests, 180 assertions)

Please review the patch.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Thanks @e.bogatyrev, that looks great, I'll run a few manual tests, but this looks like it should be good to go for a merge and release.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Reviewed & tested by the community

RTBC, thanks everyone

  • Deciphered committed d820f708 on 8.x-1.x 
    Issue #3288151 by Project Update Bot, reenaraghavan, Deciphered,...
deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.