Problem/Motivation

Float, Metatag, URI type fields are not supported by the module. An error is thrown if entity contains a field of unsupported type

Steps to reproduce

Create an entity with field iof type Float / Metatag /URI/ layout_section

Data model changes

Provide proper schema

CommentFileSizeAuthor
#16 3304201-16.patch1.86 KBmichaelsoetaert
#14 3304201-14.patch3.39 KBgaurav_manerkar
#13 3304201-13.patch2.83 KBgaurav_manerkar
#12 3304201-12.patch3.69 KBgaurav_manerkar
#11 3304201-11.patch2.08 KBgaurav_manerkar
#3 support-for-metatag-uri-and-float-type-3304201-1.patch.txt639 bytesgaurav_manerkar
#5 support-for-metatag-uri-and-float-type-3304201-1.patch639 bytesgaurav_manerkar
#7 support-for-metatag-uri-and-float-type-3304201-2.patch639 bytesgaurav_manerkar
#8 support-for-metatag-uri-and-float-type-3304201-3.patch657 bytesgaurav_manerkar

Comments

gaurav.manerkar created an issue. See original summary.

gaurav_manerkar’s picture

gaurav_manerkar commented
Title: Float, Metatag, URI type fields have a emptyschema » Float, Metatag, URI type fields have a empty schema
Status: Active » Needs review
gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new support-for-metatag-uri-and-float-type-3304201-1.patch.txt639 bytes
dmitry.korhov’s picture

dmitry.korhov
Primary language English
Location Warsaw, Poland
commented
Status: Needs review » Reviewed & tested by the community

LGTM

gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new support-for-metatag-uri-and-float-type-3304201-1.patch639 bytes
gaurav_manerkar’s picture

gaurav_manerkar commented
Title: Float, Metatag, URI type fields have a empty schema » Float, Metatag, URI and layout_section type fields have a empty schema
Issue summary: View changes
gaurav_manerkar’s picture

gaurav_manerkar commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new support-for-metatag-uri-and-float-type-3304201-2.patch639 bytes

Added support for layout_section type

gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new support-for-metatag-uri-and-float-type-3304201-3.patch657 bytes

Added support for layout_section type

gaurav_manerkar’s picture

gaurav_manerkar commented
Status: Needs review » Closed (won't fix)
gaurav_manerkar’s picture

gaurav_manerkar commented
Status: Closed (won't fix) » Needs review
gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new 3304201-11.patch2.08 KB

Created patch to support URI, Float, layout_section and metatag tyoe.

gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new 3304201-12.patch3.69 KB

Created patch to support URI, Float, layout_section and metatag type.

gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new 3304201-13.patch2.83 KB

Created patch to support URI, Float, layout_section and metatag type.

gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new 3304201-14.patch3.39 KB

Created patch to support URI, Float, layout_section and metatag type.

m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Title: Float, Metatag, URI and layout_section type fields have a empty schema » Metatag and layout_section type fields have a empty schema
Category: Support request » Bug report
Status: Needs review » Needs work

Support for float and uri were added in #3256795: Decimal and float fields have a null schema and #3390505: Error: uri is not a valid type for a JSON document.

Updated title and setting to "Needs work" to refactor accordingly.

If we want to continue with this issue we will need to add automated tests for any new additions (now that #3257911: Add basic test coverage is merged). A merge request would be preferable over patches.

michaelsoetaert’s picture

michaelsoetaert
Primary language Dutch
Location Belgium 🇧🇪
commented
StatusFileSize
new 3304201-16.patch1.86 KB

Updated patch of #14 based on comments of #15: Removed code for float & uri, as these are already supported by the latest version (1.0) of the module.