Float fields have a null schema

I spent a little time digging into this with XDebug. I found the following line in class DataDefinitionNormalizer:

const JSON_TYPES = ['null', 'boolean', 'string', 'number', 'integer', 'array', 'object'];

https://git.drupalcode.org/project/jsonapi_schema/-/blob/4f4f1b18fd9fe8f...

This gets used in that class's normalize() method:

https://git.drupalcode.org/project/jsonapi_schema/-/blob/4f4f1b18fd9fe8f...

It seems that adding float to the JSON_TYPES array fixes the issue... sort of... instead of null the schema for my float field is now:

{
  "type": "float",
  "title": "test float field"
}

However, "type": "float" is not a valid JSON Schema type. According to https://json-schema.org/understanding-json-schema/reference/numeric.html, float should be "type": "number".

I could add a simple conditional in that class to convert float to number, but that's probably not the "correct" place to handle this.

If anyone can point me in the right direction I'm happy to provide a patch! :-)

I could add a simple conditional in that class to convert float to number, but that's probably not the "correct" place to handle this.

Here is a ROUGH patch that does this. But as described above, I don't think this is the "correct" approach. Nevertheless, the patch is a quick fix for anyone who needs it (can be applied via cweagans/composer-patches).