Closed (fixed)
Project:
JSON:API Schema
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Mar 2020 at 18:00 UTC
Updated:
4 Sep 2020 at 11:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mglamanJust need to update the .info.yml
Comment #4
mglamanSo the build was successful. But I don't know if
core_version_requirementcounts until it is attempted to be installed for actual testing.Comment #5
bramdriesenAre there no deprecations and stuff to be taken care of ?
Comment #6
mglamanReviewing the following build outputs, no.
Comment #7
bramdriesenCorrect :-) also ran a pareview and gave me the same result (no deprecations but a lot of other warnings, I'll create another issue for that)
RTBC in that case :)
Comment #8
m.stentaWe are excited to include this module in farmOS, but we are building on Drupal 9 and Composer will not allow
jsonapi_schemawithout this patch. Tried applying the patch via Composer as well, but I think the dependency version checks are performed BEFORE the patch is applied, so it doesn't work. :-(I downloaded the module tarball to my local modules directory and applied the patch manually, and the module seems to work perfectly in Drupal 9! So I second the RTBC on this! :-)
Comment #9
e0ipsoLGTM.
Comment #11
e0ipsoWelcome to the future/present! 🥳
Comment #12
e0ipsoI cannot confirm or deny that my high consideration of farmOS and m.stenta was related on me jumping into this issue 😏
EDIT: sorry if I sounded like I have no consideration for the rest. I just wanted to express my liking of the project m.stenta is pushing forward. 🙏
Comment #13
m.stentaThanks you @e0ipso! For the D9 support and the kind words!! farmOS is going to make heavy use of the great work you've done in the D8/9 API initiatives! :-D