Cannot install jsonapi_schema with Drupal 9.

CommentFileSizeAuthor
#2 3118090-2.patch385 bytesmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

Status: Active » Needs review
StatusFileSize
new385 bytes

Just need to update the .info.yml

Status: Needs review » Needs work

The last submitted patch, 2: 3118090-2.patch, failed testing. View results

mglaman’s picture

Status: Needs work » Needs review

So the build was successful. But I don't know if core_version_requirement counts until it is attempted to be installed for actual testing.

bramdriesen’s picture

Status: Needs review » Needs work

Are there no deprecations and stuff to be taken care of ?

mglaman’s picture

Status: Needs work » Needs review

Are there no deprecations and stuff to be taken care of ?

Reviewing the following build outputs, no.

bramdriesen’s picture

Status: Needs review » Reviewed & tested by the community

Correct :-) also ran a pareview and gave me the same result (no deprecations but a lot of other warnings, I'll create another issue for that)

RTBC in that case :)

m.stenta’s picture

We are excited to include this module in farmOS, but we are building on Drupal 9 and Composer will not allow jsonapi_schema without this patch. Tried applying the patch via Composer as well, but I think the dependency version checks are performed BEFORE the patch is applied, so it doesn't work. :-(

I downloaded the module tarball to my local modules directory and applied the patch manually, and the module seems to work perfectly in Drupal 9! So I second the RTBC on this! :-)

e0ipso’s picture

LGTM.

  • e0ipso committed 4f4f1b1 on 8.x-1.x authored by mglaman
    Issue #3118090 by mglaman, BramDriesen, m.stenta, e0ipso: ‘...
e0ipso’s picture

Welcome to the future/present! 🥳

e0ipso’s picture

Status: Reviewed & tested by the community » Fixed

I cannot confirm or deny that my high consideration of farmOS and m.stenta was related on me jumping into this issue 😏

EDIT: sorry if I sounded like I have no consideration for the rest. I just wanted to express my liking of the project m.stenta is pushing forward. 🙏

m.stenta’s picture

Thanks you @e0ipso! For the D9 support and the kind words!! farmOS is going to make heavy use of the great work you've done in the D8/9 API initiatives! :-D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.