Problem/Motivation

Following work done in #3311240: New 2.0.x branch for PHP 8.1 / Drupal 9/10, $jsonapiClient no longer needs a separate member declaration in the class and can be property promoted in the constructor.

Steps to reproduce

N/A

Proposed resolution

As Problem/Motivation

Remaining tasks

All the things

User interface changes

None

API changes

None

Data model changes

None

Issue fork jsonapi_reference-3337250

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Eli-T created an issue. See original summary.

Eli-T opened merge request !13

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Active » Needs review
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Reviewed & tested by the community

  • Eli-T committed 1bb76232 on 2.0.x 
    #3337250: ♻️  Use property promotion for $jsonapiClient in...
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Reviewed & tested by the community » Fixed
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Fixed » Needs work

Eli-T opened merge request !14

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs work » Needs review

  • Eli-T committed 4b8eeae0 on 2.0.x 
    #3337250: ♻️ Correctly use property promotion for $jsonapiClient in...
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.