Problem/Motivation

To indicate support for Drupal 9.

Proposed resolution

Replace the core key within the info.yml with code_version_requirement and a version constraint of '^8.8 || ^9' and similar within composer.json: '^8.8 | ^9'

Remaining tasks

Change core to core_version_requirement and add the drupal/core constraint within composer.json.

User interface changes

-

API changes

-

Data model changes

-

Release notes snippet

-

CommentFileSizeAuthor
#8 interdiff.txt276 bytesjkswoods
#8 3100240-08-core_version_requirement.patch787 bytesjkswoods
#7 interdiff.txt751 bytesjkswoods
#7 3100240-07-core_version_requirement.patch786 bytesjkswoods
#4 3100240-02-core_version_requirement.patch789 bytesjkswoods
3100205-02-deprecated-code-report.patch14.31 KBjkswoods

Comments

jkswoods created an issue. See original summary.

jkswoods’s picture

jkswoods commented
jkswoods’s picture

jkswoods commented
StatusFileSize
new 3100240-02-core_version_requirement.patch789 bytes

Wrong patch... this is the right one.

jkswoods’s picture

jkswoods commented
Status: Active » Needs review
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Needs work 
+++ b/jsonapi_reference.info.yml
@@ -1,6 +1,6 @@
+core_version_requirement: ^8.8 || ^9

We have tested this on 8.7.1 and have never had to actually make any deprecations in the short lifetime of this module.

So I would suggest to set the composer required version to be minimum 8.7 or any 9, and in the info.yml file, keep the core key.

jkswoods’s picture

jkswoods commented
Status: Needs work » Needs review
StatusFileSize
new 3100240-07-core_version_requirement.patch786 bytes
new interdiff.txt751 bytes

Updated patch with the composer drupal/core constraint set to ^8.7 | ^9 and info.yml constraint core_version_requirement set to '^8 || ^9', which also includes the core key.

jkswoods’s picture

jkswoods commented
StatusFileSize
new 3100240-08-core_version_requirement.patch787 bytes
new interdiff.txt276 bytes

Updated patch to include the double pipe OR operator in composer.json instead of single pipe OR operator (which is deprecated).

  • jkswoods authored 044f59a on 8.x-1.x 
    Issue #3100240 by jkswoods, Eli-T: Add core_version_requirement to...
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.