Problem/Motivation

See #3039568-5: Add a read-only mode to JSON:API.1 and #3039568-11: Add a read-only mode to JSON:API.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3039600--route-alterations--13.patch4.81 KBe0ipso
#13 3039600--interdiff--6-13.txt2.13 KBe0ipso
#6 Screenshot 2019-03-24 at 08.54.24.png341.08 KBwim leers
#6 Screenshot 2019-03-24 at 08.53.40.png245.4 KBwim leers
#6 Screenshot 2019-03-24 at 08.53.36.png237.03 KBwim leers
#6 3039600-6.patch4.72 KBwim leers

Comments

Wim Leers created an issue. See original summary.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

@Wim Leers now that JSON:API 2.4 has been released, is this actionable?

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Postponed » Active
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Title: [PP-1] Update JSON:API Extras' route » Update JSON:API Extras' route
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » wim leers
Issue tags: +API-First Initiative

Yes!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3039600-6.patch4.72 KB
new Screenshot 2019-03-24 at 08.53.36.png237.03 KB
new Screenshot 2019-03-24 at 08.53.40.png245.4 KB
new Screenshot 2019-03-24 at 08.54.24.png341.08 KB
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Screenshots look good. I'll check the code later.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Update JSON:API Extras' route » Update JSON:API Extras' route for compatibility with JSON:API 2.4
Priority: Normal » Major

Now that #3035134: Compatibility with upcoming JSON:API 2.4 release: JSON:API Extras 3.5 landed, we should be able to do this easily.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Code looks good. There are some opinionated changes in terminology and paths that I'm neutral about.

I'll kick a test for version of core that already contains JSON:API.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

There are some opinionated changes in terminology and paths that I'm neutral about.

If they're at all contentious, I'll just change it. But per https://jsonapi.org/format/, isn't it "resource types" that you're tweaking using JSON:API Extras? You're never tweaking a node--article resource, you're tweaking the node--article resource type, and hence tweaking all node--article resources?

If you have reservations about this, I'm happy to revert those changes. I changed it because it thoroughly confused me.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Needs work

I'm wondering if this makes JSON:API Extras not compatible with the core version because they both declare the same route.

Ideally we'd want to have a single JSON:API Extras version that works for D8.6 + JSON:API contrib + JSON:API Extras and D8.7 + JSON:API Extras.

Any ideas?

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Related issues: +#3043975: Unable to install JSON:API Extras with core JSON:API using composer

I also opened #3043975: Unable to install JSON:API Extras with core JSON:API using composer to try and capture those combinations while running tests in the Drupal CI.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 3039600--interdiff--6-13.txt2.13 KB
new 3039600--route-alterations--13.patch4.81 KB

I dropped a duplicate menu. I also made some minor language changes.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs work » Needs review

  • e0ipso committed 813c80e on 8.x-3.x authored by Wim Leers 
    Issue #3039600 by Wim Leers, e0ipso: Update JSON:API Extras' route for...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

Merged! Time for a release.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#11: JSON:API 2.4 is identical to what's in core. So 8.6 or 8.5 + JSON:API 2.4 and Drupal 8.7 or 8.8 behave exactly the same for JSON:API Extras. So I don't get what you mean by "not compatible with the core version"?

#13: dropping the menu: nice one! Looks like you disagreed with #10, but that's okay — that was kind of out of scope anyway. I'm still confused by this, but I won't insist on it obviously :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.