Problem/Motivation

#2982133: No longer works with JSON API >=1.21 (so either 1.21 or 1.22) made changes to \Drupal\jsonapi_extras\JsonapiExtrasServiceProvider::alter(). It failed to take into account that during installation, default configuration is initially not available. This resulted in a PHP assertion failing, and hence installation failing.

My bad!

Proposed resolution

Only override the jsonapi.base_path container parameter if and only if the configuration is available.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2991767-2.patch705 byteswim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2991767-2.patch705 bytes

#2986900-9: Unnecessary asserts break installation in distros that include JSON API already had a patch. Reuploading that here.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

This was fixed in a parallel issue: #2995142: Support includes the EntityToJsonapi service. Sorry for missing this :-(

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.