Problem/Motivation

This came up in a discussion with @xjm.

This is similar to #3037804: Document the extent of JSON:API's multilingual support..

The difference is that unlike translations, there is no Drupal magic happening automatically that may set different expectations and results in confusing outcomes. For revisions, it's fortunately simpler: you can only read them.

Proposed resolution

Status report
Help page

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

Status: Active » Needs review
StatusFileSize
new2.35 KB
wim leers’s picture

Issue summary: View changes
StatusFileSize
new1.04 KB
new2.32 KB
new129.01 KB
new386.65 KB
jess.myrbo [20:00]
@wim.leers I think we can omit the words "due to limitations in Drupal core" since JSON:API is going to be a part of core. :slightly_smiling_face:
jess.myrbo [20:01]
@wim.leers Proposed changes (and things not to change) LGTM other than that. SS?

Done.

xjm’s picture

Status: Needs review » Needs work
+++ b/jsonapi.module
@@ -99,6 +99,9 @@ function jsonapi_help($route_name, RouteMatchInterface $route_match) {
+      $output .= '<dd>' . t('Revision support is currently read-only and only for the "Content" and "Media" entity types in JSON:API due to limitations in Drupal core. See the <a href=":jsonapi-docs">JSON:API revision support documentation</a> for more information on the current status of revision support.', [
+          ':jsonapi-docs' => 'https://www.drupal.org/docs/8/modules/jsonapi/revisions',
+        ]) . '</dd>';

One more. :)

wim leers’s picture

Status: Needs work » Needs review
StatusFileSize
new1.47 KB
new2.28 KB

Did #4 and fixed the indentation that caused the coding standards test fail.

xjm’s picture

Status: Needs review » Reviewed & tested by the community

Simple and seems sufficient, thanks @Wim Leers!

wim leers’s picture

Also crediting @gabesullice since he played a key role in #3037804: Document the extent of JSON:API's multilingual support., which this was based off.

  • Wim Leers committed 3c7bec2 on 8.x-2.x
    Issue #3039966 by Wim Leers, xjm, gabesullice: Document the extent of...
wim leers’s picture

Status: Reviewed & tested by the community » Fixed

🚢

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.