Clean-up: Remove LinkManager

This fixes most failures.

One fail. (And 5 CS violations.)

#11: Only deletes for JSON:API Extras, yay! That means less brittleness, less coupling to (private) implementation details, less future breakage 👍

1. 🎉 8 files changed, 172 insertions, 503 deletions.

2. +++ b/src/Normalizer/EntityReferenceFieldNormalizer.php
   @@ -54,10 +39,13 @@ class EntityReferenceFieldNormalizer extends FieldNormalizer {
   -    assert($context['resource_object'] instanceof ResourceIdentifierInterface);
   ...
   +    assert($context['resource_object'] instanceof ResourceObject);
   

   🤔 Why are we changing this assertion? If I revert this change, tests still pass.

3. +++ b/src/Normalizer/EntityReferenceFieldNormalizer.php
   @@ -54,10 +39,13 @@ class EntityReferenceFieldNormalizer extends FieldNormalizer {
   +    $links = array_map(function (Url $link) use ($link_cacheability) {
   +      $href = $link->setAbsolute()->toString(TRUE);
   +      $link_cacheability->addCacheableDependency($href);
   +      return ['href' => $href->getGeneratedUrl()];
   +    }, $this->getRelationshipLinks($context['resource_object'], $field->getName()));
   

   👍 Elegant!

4. +++ b/tests/src/Functional/MessageTest.php
   @@ -26,6 +26,7 @@ class MessageTest extends ResourceTestBase {
   +
   

   🔍🐛 Accidental whitespace-only change, let's revert.

5. +++ b/tests/src/Kernel/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php
   @@ -279,8 +272,8 @@ class JsonApiDocumentTopLevelNormalizerTest extends JsonapiKernelTestBase {
   -        'self' => ['href' => 'dummy_entity_link'],
   -        'related' => ['href' => 'dummy_entity_link'],
   +        'self' => ['href' => Url::fromUri('internal:/jsonapi/node/article/' . $this->node->uuid() . '/relationships/uid')->setAbsolute()->toString(TRUE)->getGeneratedUrl()],
   +        'related' => ['href' => Url::fromUri('internal:/jsonapi/node/article/' . $this->node->uuid() . '/uid')->setAbsolute()->toString(TRUE)->getGeneratedUrl()],
   

   👌

6. --- a/tests/src/Unit/LinkManager/LinkManagerTest.php
   +++ /dev/null
   

   ✅ This test coverage is hardly worth keeping, it's far more complex than the trivial code it provides test coverage for. Plus, our functional tests more than cover this.

   +++ /dev/null
   @@ -1,218 +0,0 @@
   -  public function testGetPagerLinks($offset, $size, $has_next_page, $total, $include_count, array $pages) {
   ...
   -  public function getPagerLinksProvider() {
   

   Only this test coverage is testing nontrivial code, but here too the test coverage is so tightly coupled to implementation details and burdened with such complex mocks that it is not at all clear how much reassurances this is actually getting us.

I'd fix point 4 on commit, but keeping NR for point 2.

which type hints ResourceObject

But that too doesn't use anything on ResourceObject, it only uses methods on ResourceIdentifierInterface. So why can't we just typehint to that?

That is a solid reason. I'm convinced :)

I'm RTBC'ing and committing because:

1. this is requested by a core committer in #2843147-122: Add JSON:API to core as a stable module.4
2. I am pretty confident @e0ipso agrees with this since he committed #3032468: Compatibility with upcoming JSON:API 2.2 release: JSON:API Extras 3.4 , which is also using the LinkCollection (the new intended API) infrastructure instead of LinkManager (the originally intended API)