Closed (fixed)
Project:
JSON:API
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
2 Jul 2018 at 10:00 UTC
Updated:
28 Nov 2019 at 05:54 UTC
Jump to comment: Most recent, Most recent file
The JSON API core patch at #2843147-62: Add JSON:API to core as a stable module has 48 fails, 46 of which because of remaining deprecation notices. We should set up JSON API's 2.x branch to have the same failures so we can fix them.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 2982964-11.patch | 7.04 KB | wim leers |
| #11 | interdiff.txt | 1.93 KB | wim leers |
| #9 | 2982964-9.patch | 7.02 KB | wim leers |
| #9 | interdiff.txt | 1001 bytes | wim leers |
| #7 | 2982964-7.patch | 6.6 KB | wim leers |
Comments
Comment #2
wim leersComment #3
wim leersNow moved it to the right location.
Comment #5
wim leersYay, that worked!
Comment #6
wim leersComment #7
wim leersYay, green again!
I see that there's also 2 CS violations introduced by #2957474: Move the write functionality of config entities to a sub-module in preparation for removal. Let's fix those here too, a separate issue for that seems excessive.
Comment #8
wim leersComment #9
wim leers#6 introduced two other CS violations; fixing those.
Comment #10
wim leersComment #11
wim leersD'oh.
Comment #12
wim leersComment #14
wim leersComment #15
wim leersFollow-up: #2983196: Fix all deprecation errors in Drupal 8.6.
Comment #16
wim leersComment #18
kristen polPer a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.