#2950125: Add helpful reason for 'update' and 'delete' access not being allowed to CommentAccessControlHandler improved CommentAccessControlHandler, we now need JSON API's test coverage to be updated to remain in sync.

CommentFileSizeAuthor
#3 2966363-3.patch844 byteswim leers
#3 interdiff.txt970 byteswim leers
#2 2966363-2.patch691 byteswim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2966363-2.patch691 bytes

See failure at https://www.drupal.org/pift-ci-job/948900. This should make it green again.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff.txt970 bytes
new 2966363-3.patch844 bytes

I just realized #2 is wrong; it should only apply that logic to 8.6 and later.

The last submitted patch, 2: 2966363-2.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community

Green on both 8.5 and 8.6 now :)

  • Wim Leers committed ca8b916 on 8.x-1.x 
    Issue #2966363 by Wim Leers: CommentTest::testPatchIndividual() failing...
  • Wim Leers committed a2207ea on 8.x-2.x
    Issue #2966363 by Wim Leers: CommentTest::testPatchIndividual() failing...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Category: Bug report » Task

This wasn't a bug; it was a task: staying in sync with upstream changes in core's next minor.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.