Per #2931785: The path for JSON API to core:

  1. TODO (test that custom modules' format-agnostic field type normalizers ARE NOT picked up)
  2. TODO (test that custom modules' format-agnostic data type normalizers ARE picked up)

Perhaps unsurprisingly, it turns out that it's probably best that we test both in a single test, much of the infrastructure they need is shared.

CommentFileSizeAuthor
#11 2950486-11.patch9.57 KBwim leers
#11 interdiff-8-11.txt836 byteswim leers
#10 2950486-10.patch25.39 KBwim leers
#10 interdiff-8-10.txt16.66 KBwim leers
#8 2950486-8.patch9.57 KBwim leers
#8 interdiff-5-8.txt3.52 KBwim leers
#5 2950486-5.patch9.35 KBwim leers
#5 interdiff-4-5.txt5.2 KBwim leers
#4 2950486-4.patch10.05 KBwim leers
#4 interdiff-3-4.txt6.67 KBwim leers
#3 2950486-3.patch10.07 KBwim leers
#3 interdiff-2-3.txt4.64 KBwim leers
#2 2950486-2.patch5.98 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2950486-2.patch5.98 KB

Let's kick this off with test coverage for @FieldType-level normalizers.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff-2-3.txt4.64 KB
new 2950486-3.patch10.07 KB

Let's add @DataType-level normalizer test coverage.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff-3-4.txt6.67 KB
new 2950486-4.patch10.05 KB

Let's make this more robust, and easier to scan+understand.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff-4-5.txt5.2 KB
new 2950486-5.patch9.35 KB

Much of the assertions are the same. Let's use a @dataProvider to make this 10x easier to understand and maintain. This now makes the expected differences super obvious!

The last submitted patch, 3: 2950486-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 2: 2950486-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
StatusFileSize
new interdiff-5-8.txt3.52 KB
new 2950486-8.patch9.57 KB

Haha, #2 and #3 would also have passed, if it weren't for the fact that in my rebasing, I accidentally moved some things from later commits into earlier commits, and hence broke the tests. Ah well.

Fixing CS violations.

IMHO this is RTBC-worthy.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Needs work 
+++ b/tests/src/Functional/ExternalNormalizersTest.php
@@ -0,0 +1,149 @@
+      'Format-agnostic @DataType-level normalizers SHOULD be able to affect the JSON API normalization' => [
+        // \Drupal\jsonapi_test_field_type\Normalizer\StringNormalizer::normalize()

s/jsonapi_test_field_type/jsonapi_test_data_type/

I think

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-8-10.txt16.66 KB
new 2950486-10.patch25.39 KB

🦅👀

👍

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff-8-11.txt836 bytes
new 2950486-11.patch9.57 KB

Ignore #10, unwanted cruft in there.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

  • Wim Leers committed 0492966 on 8.x-1.x 
    Issue #2950486 by Wim Leers, gabesullice: Test coverage: custom modules...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.