The sort parameter is designed to accept a langcode property which should be passed to the sort() method of the Query object.

CommentFileSizeAuthor
#9 jsonapi-2914221-9.patch1.28 KBgarphy
#9 jsonapi-2914221-9-tests.patch878 bytesgarphy
#5 jsonapi-2914221-5.patch1.29 KBgarphy
#5 jsonapi-2914221-5-testonly.patch886 bytesgarphy
#2 jsonapi-2914221-1.test-only.patch1.29 KBgarphy

Comments

garphy created an issue. See original summary.

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
StatusFileSize
new jsonapi-2914221-1.test-only.patch1.29 KB

Patch with unit test coverage (as the name does not suggest).

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
Status: Active » Needs review

Bot, please.

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented

Side note : should we open a follow-up issue to implement full test coverage of every QueryOptionInterface implementations ? AFAICT there's basically no test here.

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
StatusFileSize
new jsonapi-2914221-5-testonly.patch886 bytes
new jsonapi-2914221-5.patch1.29 KB

Test-only patch & bugfix patch correctly named.

The last submitted patch, 5: jsonapi-2914221-5-testonly.patch, failed testing. View results

The last submitted patch, 2: jsonapi-2914221-1.test-only.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 5: jsonapi-2914221-5.patch, failed testing. View results

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new jsonapi-2914221-9-tests.patch878 bytes
new jsonapi-2914221-9.patch1.28 KB

Fixed @coversDefaultClass.

The last submitted patch, 9: jsonapi-2914221-9-tests.patch, failed testing. View results

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
Status: Needs review » Closed (duplicate)
Related issues: +#2874601: refactor(QueryBuilder): Improve testability/maintainability

It seems that the issue is addressed in #2874601: refactor(QueryBuilder): Improve testability/maintainability.
Oddly, the "sort language" search term didn't show it when I first checked the issue queue.
I'm going to review the patch there to check for this specific bug.