Coding Standard Issue [#3276906]

Problem/Motivation

FILE: D:\projects\lando-d8\web\modules\contrib\jquery_colorpicker\includes\jquery_colorpicker.theme.inc
-------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------
17 | ERROR | [x] Use null coalesce operator instead of ternary operator.
18 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

FILE: D:\projects\lando-d8\web\modules\contrib\jquery_colorpicker\src\Plugin\Field\FieldFormatter\JqueryColorpickerColorDisplayFormatter.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FOUND 2 ERRORS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

16 | ERROR | The text '@deprecated as of Jquery Colorpicker update 8200. Will be removed in Jquery Colorpicker 8.x-3.x, and/or 9.x-1.x. Running jquery_colorpicker_update_8200() requires the existence of this
| | formatter, however the field type is obsolete after that update has been run.' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%.
| | %extra-info%.
16 | ERROR | Each @deprecated tag must have a @see tag immediately following it
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\projects\lando-d8\web\modules\contrib\jquery_colorpicker\src\Plugin\Field\FieldFormatter\JqueryColorpickerDisplayFormatterBase.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

11 | ERROR | The text '@deprecated as of Jquery Colorpicker update 8200. Will be removed in Jquery Colorpicker 8.x-3.x, and/or 9.x-1.x. Running jquery_colorpicker_update_8200() requires the existence
| | formatters that, extend this class, however the field type is obsolete after that update has been run, so this will be removed.' does not match the standard format: @deprecated in
| | %deprecation-version% and is removed from %removal-version%. %extra-info%.
11 | ERROR | Each @deprecated tag must have a @see tag immediately following it
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\projects\lando-d8\web\modules\contrib\jquery_colorpicker\src\Plugin\Field\FieldFormatter\JqueryColorpickerRawHexDisplayFormatter.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

17 | ERROR | The text '@deprecated as of Jquery Colorpicker update 8200. Will be removed in Jquery Colorpicker 8.x-3.x, and/or 9.x-1.x. Running jquery_colorpicker_update_8200() requires the existence of this
| | formatter, however the field type is obsolete after that update has been run.' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%.
| | %extra-info%.
17 | ERROR | Each @deprecated tag must have a @see tag immediately following it
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\projects\lando-d8\web\modules\contrib\jquery_colorpicker\src\Plugin\Field\FieldFormatter\JqueryColorpickerRawRgbDisplayFormatter.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\projects\lando-d8\web\modules\contrib\jquery_colorpicker\src\Plugin\Field\FieldFormatter\JqueryColorpickerTextDisplayFormatter.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\projects\lando-d8\web\modules\contrib\jquery_colorpicker\src\Plugin\Field\FieldType\JqueryColorpickerColorItem.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

19 | ERROR | The text '@deprecated as of Jquery Colorpicker update 8200. Will be removed in Jquery Colorpicker 8.x-3.x, and/or 9.x-1.x. Running jquery_colorpicker_update_8200() requires the existence of this
| | field type, however the field type is obsolete after that update has been run. As such, if the schema version is equal to or above 8200, the field type is removed from the list of field types in
| | jquery_colorpicker_field_info_alter().' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%.
19 | ERROR | Each @deprecated tag must have a @see tag immediately following it
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\projects\lando-d8\web\modules\contrib\jquery_colorpicker\src\Plugin\migrate\field\JqueryColorpicker.php
----------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
26 | ERROR | [x] Expected 1 blank line before function; 0 found
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
45 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
67 | ERROR | [x] Expected 1 blank line after function; 0 found
68 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------

FILE: D:\projects\lando-d8\web\modules\contrib\jquery_colorpicker\tests\src\Unit\Service\jQueryColorpickerServiceTest.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------
14 | ERROR | Class name doesn't match filename; expected "class jQueryColorpickerServiceTest"
22 | ERROR | Class property $JQueryColorpickerService should use lowerCamel naming without underscores
-------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal /d/projects/lando-d8/web/modules/contrib/jquery_colorpicker

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#7	3276906-7.patch	12.56 KB	urvashi_vora

Issue fork jquery_colorpicker-3276906

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3276906-coding-standard-issue changes, plain diff MR !6
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

25 April 2022 at 07:19

Rashmisoni created an issue. See original summary.

Comment #2

rassoni commented 25 April 2022 at 08:39

Assigned:

rassoni

» Unassigned

Comment #3

sharayurajput commented 25 April 2022 at 08:48

Assigned:

Unassigned

» sharayurajput

Comment #4

25 April 2022 at 17:03

sharayurajput opened merge request !6

Comment #5

sharayurajput commented 26 April 2022 at 13:07

Assigned:

sharayurajput

» Unassigned

Comment #6

urvashi_vora commented 16 May 2022 at 05:55

Assigned:

Unassigned

» urvashi_vora

Comment #7

urvashi_vora commented 16 May 2022 at 06:05

Status:

Needs work

» Needs review

Status	File	Size
new	3276906-7.patch	12.56 KB

Hi,

Please review this patch. I tried resolving all deprecation-related errors and warnings.

Thanks

Comment #8

neslee canil pinto

he/him

English

commented 29 May 2022 at 08:22

Version:

8.x-2.0

» 8.x-2.x-dev

Comment #9

urvashi_vora commented 22 June 2022 at 05:11

Assigned:

urvashi_vora

» Unassigned

Comment #10

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

commented 20 July 2022 at 13:52

Version:	8.x-2.x-dev	» 3.0.x-dev
Status:	Needs review	» Needs work

MBP-Andrii:jquery_colorpicker podarok$ git apply 3276906-7.patch
error: patch failed: tests/src/Unit/Service/jQueryColorpickerServiceTest.php:1
error: tests/src/Unit/Service/jQueryColorpickerServiceTest.php: patch does not apply

Please reroll

Comment #11

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

commented 20 July 2022 at 14:02

Status:

Needs work

» Fixed

Thanks all

Comment #12

3 August 2022 at 14:04

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Coding Standard Issue

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork jquery_colorpicker-3276906

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

News items

Our community

Documentation

Drupal code base

Governance of community