Closed (fixed)
Project:
jQuery carousel
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Sep 2015 at 01:05 UTC
Updated:
25 Feb 2016 at 17:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
piyuesh23 commentedThe interval configuration has been moved to another keyword called pause in the library. Updated the module to handle that.
Uploading patch for the fix.
Comment #3
piyuesh23 commentedComment #4
piyuesh23 commentedComment #5
naveenvalechacorrecting version
Comment #6
naveenvalechaWell patch looks good to me. We need hook_update for updating the config of existing jquery_carousel config ?
Reg. css change,@saki007ster would be happy with that.
Comment #7
piyuesh23 commented@naveenvalecha,
Thanks for the quick review. Don't think we need an update hook here right away. There could be multiple fields with the configuration for the same. In any case, the default value for pause setting is picked up by the jQuery plugin whenever its not available.
Comment #9
piyuesh23 commentedComment #10
naveenvalechaComment #11
naveenvalechaRe #7 : Agreed, the default value is controlled by the module and we are not allowing anywhere user to update the default value. but it is needed for the interval -> pause key that we are updating, its needed b/c the old key will left in system.If we are not doing then we are leaving our mess in existing config.
+1 yep let's use this as a fallback