Making changes to the css is hard. At least it was. I have added a field to the jPlayer admin settings (admin/config/media/jplayer) which allows people to customize where the jplayer.css resides. Yes. No more modifying the jplayer module file structure. The caveat is that the file MUST be called jplayer.css. I am adding the patch here for your reviewing pleasure, but I have tested and am pretty happy with the results and will most likely push it by the end of the weekend.

Comments

markie’s picture

StatusFileSize
new1.97 KB

Patch as promised.

damienmckenna’s picture

Status: Active » Needs review
damienmckenna’s picture

Status: Needs review » Needs work

A quick suggestion - the if() statement should check if $varpath is empty, i.e. if (!empty($varpath)) {}.

Also, it needs a line added to hook_uninstall() for the new variable.

markie’s picture

Status: Needs work » Needs review
StatusFileSize
new2.61 KB

@DamienMcKenna: thanks a ton for quickly looking at this. I added the empty check and added a variable_del() for ALL the variables in the admin form, just for consistency. Please give it another go.

damienmckenna’s picture

Status: Needs review » Needs work

Better. The only thing I'll mention is that the variable_get() calls don't need the second argument of NULL or an empty string because the default is NULL, which will satisfy both uses.

markie’s picture

Status: Needs work » Needs review
StatusFileSize
new0 bytes

@DamienMcKenna thanks again for your quick comments. New patch submitted for your approval.

damienmckenna’s picture

@markie: The patch was empty ;)