Closed (fixed)
Project:
jCarousel
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Sep 2009 at 13:58 UTC
Updated:
13 Dec 2010 at 07:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
robloachYou mean having the same name for different skins? If you visit admin/help/jcarousel, you'll see there's use of different skins on the same page....
Comment #2
chirale commentedThis example show three different themes, but only one custom theme. This issue rises only when there are 2 or more custom skin declared in the same page, since the
$jcarousel_added['skin'][$skin] = TRUE;is set only one time when $skin = 'custom'.Creating a new array that relying also on paths for custom themes solve this issue.
Comment #3
trevorwh commentedI can confirm this issue.
I haven't tested the patch above, but two custom skins definitely conflict.
Comment #4
hefox commentedit's not just adding the css; all custom skins are named custom, so no way to nicely identify things in the css
Need a name/identifier for the custom css or such.
Patch works for the duplicate though.
Comment #5
dgtlife commentedFor those looking for a resolution to the issue of multiple custom skins on the same page, but not inclined to deploy a -dev release, I confirm that the issue manifests in 6.x-1.1, and is eliminated by the application of the patch to that version.
It's a great module, and I'd like to thank Rob and other contributors for their effort in producing it...and to chirale for producing the patch.
Comment #6
sp3boy commentedAnother vote of appreciation - this patch applies to 6.x-1.1 and may save my... er, skin for a site page with multiple carousels that I should have finished two days ago.
I still have conflicting CSS but at least if both skin CSS files are loaded I can resolve that hopefully.
Comment #7
sp3boy commentedPatch needed rebuilding after recent commits. No functional difference to previous one.
Comment #8
quicksketchThe 1.x version probably won't be receiving any further updates, but I've checked that this is not a problem with using jcarousel_add() in the 2.x version. Note that the parameters for the jCarousel 2.x version have changed (there's no longer individual $skin and $skin_path parameters).