what a huge patch ^^

CommentFileSizeAuthor
#11 jcarousel.d6.patch2.68 KBaaron
#10 jcarousel.d6.patch1.53 KBaaron
#9 jcarousel.d6.patch1.48 KBaaron
#8 jcarousel_6.patch541 bytesdawehner
#5 jcarousel_6.patch556 bytesdawehner
#2 jcarousel_6_2.patch1.06 KBdawehner
#1 jcarousel_6_1.patch1.07 KBdawehner
jcarousel_6.patch1.02 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new jcarousel_6_1.patch1.07 KB

forgot to change dependencies[]

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new jcarousel_6_2.patch1.06 KB

i think the module doesn't really need this dependencie any more because drupal6.x brings a new jquery version with it

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
spiffyd’s picture

spiffyd commented

Your patch doesn't work, it gets rejected. Can you confirm (or better yet attach) the jcarousel 5.x module you patched?

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new jcarousel_6.patch556 bytes

here is another patch which uses -r DRUPAL-5 as base

i used the HEAD which wasen't the same as DRUPAL-5

spiffyd’s picture

spiffyd commented

would you kindly tell me where i can find the head module or attach it for which this patch works against? i was using this: http://drupal.org/node/162101 which the patch doesn't work for.

As for you patch in #5.. it didn't work for this module as well.

please advise.

spiffyd’s picture

spiffyd commented

Is anyone working on porting this 6.x at this moment?

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new jcarousel_6.patch541 bytes

i wrote the patch for the current dev version downloaded at http://drupal.org/node/162101

aaron’s picture

aaron commented
Title: Port to 6.x » Port jCarousel to 6.x
StatusFileSize
new jcarousel.d6.patch1.48 KB

wow, not sure how i missed this issue. here's a version that adds support for jQ as well. This creates a new .jq.inc file for jQ integration. (No code added to the actual module; that file is included conditionally only when needed by the optional jQ module.) Patch is against current HEAD.

duplicate issue is #317730: Port jCarousel to D6. sorry for the confusion.

aaron’s picture

aaron commented
StatusFileSize
new jcarousel.d6.patch1.53 KB

and here it is against DRUPAL-5... helps to read the issues...

note this also fixes the issue for package of 'User interface' at #269924: Change from "User Interface" to "User interface"

aaron’s picture

aaron commented
StatusFileSize
new jcarousel.d6.patch2.68 KB

ok, hadn't realized #218142: Allow for custom skin paths was never committed. this patch takes that into account, and fixes a problem in the jq.inc file as well.

robloach’s picture

robloach
he/him
commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Fixed

DRUPAL-6--1 open, 6.x-1.x-dev created, and 1.0 released.

Ability for custom skins, jQ support, ability to add jCarousels directly from PHP without writing any JavaScript, demonstrations in admin/help/jcarousel, it's all in there! :-)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks Rob Loach :)

Do you want to become the official maintainer or not?

robloach’s picture

robloach
he/him
commented

Uhh, sure, but it really doesn't matter... I'm not working on anything right now that uses the DRUPAL-5 branch at the momment, but wouldn't have a problem committing things marked RTBC.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.